DisplayList DlMaskFilter objects #31535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Feb 18, 2022
|
|
||
| class DlBlurMaskFilter; | ||
|
|
||
| // The DisplayList MaskFilter class. This class was designed to be: |
There was a problem hiding this comment.
Would it make sense to have an abstract class with this documentation on it, and have these classes implement it?
For example, it might specify a virtual type, size, shared, skia_shared or something?
There was a problem hiding this comment.
That's an idea. I might go for that on the next attribute I convert.
dnfield
approved these changes
Feb 18, 2022
flar
force-pushed
the
displaylist-maskfilter-objects
branch
from
68275d4 to
3a99bfb
Compare
flar
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#98714
This PR is similar to #31491 which created a DisplayList-specific, inspectable object to hold all of our color filters. This PR does the same for our mask filter.