Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Added dart plugin registrant test executables to run_tests.py #31726

Merged
gaaclarke merged 1 commit into from
Mar 1, 2022
Merged

Added dart plugin registrant test executables to run_tests.py #31726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion runtime/dart_isolate.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,8 @@ bool EndsWith(const std::string& str, const std::string& ending) {
}

Dart_Handle FindDartPluginRegistrantLibrary() {
// TODO(): Instead of finding this, it could be passed down from the tool.
// TODO(99308): Instead of finding this, it could be passed down from the
// tool.
Dart_Handle libraries = Dart_GetLoadedLibraries();
intptr_t length = 0;
Dart_ListLength(libraries, &length);
Expand Down
4 changes: 4 additions & 0 deletions testing/run_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,10 @@ def RunCCTests(build_dir, filter, coverage, capture_core_dump):

RunEngineExecutable(build_dir, 'tonic_unittests', filter, shuffle_flags, coverage=coverage)

RunEngineExecutable(build_dir, 'no_dart_plugin_registrant_unittests', filter, shuffle_flags, coverage=coverage)

RunEngineExecutable(build_dir, 'dart_plugin_registrant_unittests', filter, shuffle_flags, coverage=coverage)

if not IsWindows():
# https://github.com/flutter/flutter/issues/36295
RunEngineExecutable(build_dir, 'shell_unittests', filter, shuffle_flags, coverage=coverage)
Expand Down