Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Migrate Flutter Web to JS static interop - 2. #32427

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

joshualitt
Copy link
Contributor

This is CL 2 in a series of CLs to migrate Flutter Web to the new JS static interop API.

This CL migrates a few of the simpler classes in canvaskit_api.dart to the new JS static interop API.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Apr 5, 2022
@joshualitt
Copy link
Contributor Author

@srujzs ptal for a first pass, I don't think anything here will be controversial.

I'm not exactly sure how to work off a branch of a branch in github, but please only look at patch #2, patch #1 has already been reviewed.

Note: I will let patch #1 sit for a full 24 hours before trying to land this one.

@srujzs
Copy link
Contributor

srujzs commented Apr 5, 2022

LGTM.

@joshualitt joshualitt marked this pull request as ready for review April 5, 2022 21:27
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Hixie
Copy link
Contributor

Hixie commented Apr 6, 2022

test-exempt: code refactor with no semantic change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs tests platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants