-
Notifications
You must be signed in to change notification settings - Fork 6k
[Linux] add missing AtkObject::get_index_in_parent implementation #32499
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@jpnurmi can you think of a way we can write a test for this? |
|
Sure, I'll come up with something 👍 |
|
I'm glad you asked me to add a test because it made me realize that the first fix attempt wasn't really correct. 🙂 |
cbracken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
This pull request is not suitable for automatic merging in its current state.
|
|
Added @chunhtai for second review. |
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Due to missing
AtkObject::get_index_in_parentimplementation, the Orca screen reader would lose track of accessibility objects and they would turn to "zombies".Fixes: flutter/flutter#101513
See also: https://gitlab.gnome.org/GNOME/orca/-/blob/master/src/orca/script_utilities.py#L5041
Pre-launch Checklist
writing and running engine tests.
///).