[web] Migrate Flutter Web to JS static interop - 7. #32519
Conversation
|
@srujzs ptal. Mostly just a trivial migration, aside from:
|
| class _CkCubicFilterOptions extends CkFilterOptions { | ||
| external double get B; |
There was a problem hiding this comment.
What errors were you getting from moving these to extensions? Are these unused (similar question for the other removed members)?
There was a problem hiding this comment.
Yea, they appear to be unused and so the analyzer warned. The flutter web project has a check that turns the analyzer warnings to errors. It sort of makes sense that the analyzer is stricter with extension methods because they are static.
I'm not sure what we can really do here other than maybe some annotation that makes the warnings go away, but given that the methods really are seemingly unused, it may make sense to just remove them.
There was a problem hiding this comment.
Agreed, I was just mostly curious why warnings started to appear now instead of before when they were unused anyways.
|
LGTM |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
joshualitt
requested review from
yjbanov and
eyebrowsoffire
and removed request for
yjbanov
|
test-exempt: code refactor with no semantic change |
This is CL 7 in a series of CLs to migrate Flutter Web to the new JS static interop API.
This CL migrates more of canvaskit_api.dart(about 59% through that file).