Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use only mac x64 machines. #32752

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Use only mac x64 machines. #32752

merged 1 commit into from
Apr 18, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Apr 18, 2022

Mac host engine is failing on Mac M1s because CIPD packages for goma
and Android are not available for arm64.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Use only mac x64 machines.
14a423c 
Mac host engine is failing on Mac M1s because CIPD packages for goma
and Android are not available for arm64.
keyonghan
keyonghan suggested changes Apr 18, 2022
View reviewed changes
ci/builders/mac_host_engine.json
"device_type=none",
"os=Mac-12"
"os=Mac-12",
"cpu=x64"
Copy link
Contributor

@keyonghan keyonghan Apr 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall this be cpu=x86?

Copy link
Contributor Author

@godofredoc godofredoc Apr 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any x86 machines, I believe if x86 is there is for backward compatibility.

keyonghan
keyonghan approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 18, 2022
@fluttergithubbot fluttergithubbot merged commit f75ff2b into flutter:main Apr 18, 2022
@godofredoc godofredoc deleted the add_dimension_mhe branch April 18, 2022 22:40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 19, 2022
@engine-flutter-autoroll
f75ff2b Use only mac x64 machines. (flutter/engine#32752)
cc6915d
justinmc pushed a commit to justinmc/engine that referenced this pull request Apr 20, 2022
@godofredoc @justinmc
Use only mac x64 machines. (flutter#32752)
d021f5a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@keyonghan keyonghan keyonghan approved these changes

@yusuf-goog yusuf-goog yusuf-goog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@godofredoc @keyonghan @yusuf-goog @fluttergithubbot