Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text gradient matrix golden test #33153

Merged

Conversation

flar
Copy link
Contributor

@flar flar commented May 6, 2022

Fixes flutter/flutter#103155

#33131 was submitted without a golden test. It's API tests don't verify the actual rendering of the original test case. This PR adds the golden test.

@flar flar requested review from jason-simmons and chinmaygarde May 6, 2022 00:05
@flar flar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 6, 2022
@fluttergithubbot fluttergithubbot merged commit c8ccb26 into flutter:main May 6, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create golden test to verify the rendering output of the fix for text with matrix gradients
3 participants