This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland: Roll clang and buildroot #33325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
May 13, 2022
| @@ -0,0 +1,6 @@ | |||
| # These symbols are looked up from within the executable at runtime and must | |||
| # be exported in the dynamic symbol table. | |||
Contributor
There was a problem hiding this comment.
Consider adding a comment about why we have a different file here for mac than exported_symbols.sym.
Member
Author
There was a problem hiding this comment.
I added a comment in the GN build file.
dnfield
approved these changes
May 13, 2022
Member
|
Note this also pulls in flutter/buildroot@d243d31 and flutter/buildroot@c865293 which wasn't mentioned in #33284 |
zanderso
added a commit
that referenced
this pull request
May 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 14, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
) This reverts commit fd8b205.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of #33284. In the original attempt, Dart snapshot symbols were not exposed properly and so
flutter_testerinitialization failed inhost_debugbuilds. Since we're now using a new linker, this PR includes updated linker flags in//flutter/BUILD.gnto ensure the symbols are available.Before landing this, I'll land a recipe change to increase test coverage on engine CI to catch similar problems in the future.