This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Swap the order of processing GCS_RESULTSTR and GCS_COMPSTR to fix the behavior of partial committing with Google Japanese Input #33605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r commit text partially
cbracken
approved these changes
May 27, 2022
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
I'll do a quick manual check to verify this works for Korean input and if so, will merge. I'll also see if I can find a way to add a test for Korean input case, since its behaviour is a bit different from Japanese and Chinese.
Member
|
Did some quick testing and looks good! Thanks for your fix! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 1, 2022
…red after commit text partially (flutter/engine#33605)
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
…r commit text partially (flutter#33605) Reproducible steps is in flutter/flutter#102021. Fixes flutter/flutter#102021. No changes in [flutter/tests] repo.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducible steps is in flutter/flutter#102021.
Fixes flutter/flutter#102021.
No changes in flutter/tests repo.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.