-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland No.2 "Hardware Keyboard: Android" #33686
Merged
dkwingsmt
merged 3 commits into
flutter:main
from
dkwingsmt:reland-2-android-key-embedder-responder
May 31, 2022
Merged
Reland No.2 "Hardware Keyboard: Android" #33686
dkwingsmt
merged 3 commits into
flutter:main
from
dkwingsmt:reland-2-android-key-embedder-responder
May 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
embedder
Related to the embedder API
platform-android
labels
May 29, 2022
dkwingsmt
force-pushed
the
reland-2-android-key-embedder-responder
branch
from
May 30, 2022 08:54
7e2b662
to
4d6ae33
Compare
gspencergoog
approved these changes
May 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2022
8 tasks
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
* Original code * Changes * Fix and test Better formatted tests
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #33113, which was reverted due to possible internal breakages.
Changes based on original PR: (See latest commits)
I have tested this PR on g3 (with necessary modifications due to problems of the rolling script.)
This PR implements the embedder keyboard responder of the Android embedding, the backend of
HardwareKeyboard
on Android. This is the last platform to support it.The behaviors are tested on a ChromeOS over ARC++. There are some weird behaviors, mostly for
metaState
, which are very likely the fault of ARC++ or Android. Therefore the synchronization logic is implemented in a loose way.There are a few known issues:
This PR assigned a new code plane
kLogicalPlane
for the physical keys that are improvised from the logical keys.Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.