Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

@jpnurmi
Copy link
Member

jpnurmi commented Jun 27, 2022

I had also a fix prepared if it's still an option: #34312

@zanderso
Copy link
Member Author

There are also build failures in the logs, so I'm not sure that #34312 will be sufficient to re-open the tree.

@zanderso zanderso added warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App labels Jun 27, 2022
@jpnurmi
Copy link
Member

jpnurmi commented Jun 27, 2022

It has fixes to both, the clang-tidy changes introduced by #33692 and the MockBinaryMessenger API change in #33955. All jobs except luci-engine are green.

@zanderso
Copy link
Member Author

Closing in favor of forward fix #34312

@zanderso zanderso closed this Jun 27, 2022
@zanderso zanderso deleted the revert-33313-a11y-features branch June 27, 2022 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-linux warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants