This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Include TextureLayer in contents of toImageSync #35608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 7, 2022 15:36
…ne into hack_for_texture_view
…ne into hack_for_texture_view
added 8 commits
August 18, 2022 23:53
dnfield
reviewed
Aug 22, 2022
shell/common/rasterizer.cc
Outdated
| } | ||
|
|
||
| GrDirectContext* Rasterizer::GetGrContext() { | ||
| return surface_->GetContext(); |
Contributor
There was a problem hiding this comment.
Suggested change
| return surface_->GetContext(); | |
| return surface_ ? surface_->GetContext() : nullptr; |
Contributor
Author
There was a problem hiding this comment.
nullsafety for c++ when?
Contributor
There was a problem hiding this comment.
Something something billion dollar mistake
Contributor
Author
|
This is almost ready again, but I need to do another local engine build and verify the test now passes |
dnfield
approved these changes
Aug 22, 2022
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM as long as the internal test is passing.
Contributor
Author
|
It passed: http://sponge2/ad365424-d3c9-485e-b628-98f0b80d8686 :D |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2022
8 tasks
dkwingsmt
added a commit
that referenced
this pull request
May 5, 2023
This PR fixes flutter/flutter#112202. `Scene` is no longer tied to views, but receives method arguments for view properties, clearing the path to multiview Flutter. `Scene` no longer creates a `LayerTree` on construction, but only part of the config. When a output method is called (`toImage`, `toImageSync`, or `takeLayerTree`), the `LayerTree` is constructed on the spot. In this way, all `LayerTree`s return to being `unique_ptr`s instead of `shared_ptr`s, reverting part of #35608 . And `Scene` no longer needs to disfunction after one `takeLayerTree`, since the layer tree config is never really taken away. A `device_pixel_ratio` is now added to the parameter list of `Engine::Render` and `Animator::Render`. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See revert #35587
Fixes NPE in GetGrContext