Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Made sure to call the plugin registrant when registering a background isolate #36383

Merged
auto-submit merged 1 commit into from
Sep 23, 2022
Merged

Made sure to call the plugin registrant when registering a background isolate #36383

auto-submit merged 1 commit into from
Sep 23, 2022

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Sep 23, 2022 •
edited
Loading

fixes flutter/flutter#112240

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke force-pushed the register-background-isolate-registrant branch from c4badf0 to 7110f46 Compare September 23, 2022 17:43
@gaaclarke gaaclarke force-pushed the register-background-isolate-registrant branch from 7110f46 to d094866 Compare September 23, 2022 17:43
@gaaclarke gaaclarke marked this pull request as ready for review September 23, 2022 17:43
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2022
@auto-submit auto-submit bot merged commit 04bd25b into flutter:main Sep 23, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 23, 2022
@engine-flutter-autoroll
04bd25b Made sure to call the plugin registrant when registering a ba…
bae6750 
…ckground isolate (flutter/engine#36383)
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
@gaaclarke
Made sure to call the plugin registrant when registering a background…
baea893 
… isolate (flutter#36383)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Plugins with dart plugin registrants don't work on background isolates

2 participants

@gaaclarke @dnfield