Fix editing delta is wrong when using delete key
#36616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renzo-Olivares
approved these changes
Oct 5, 2022
| @@ -497,7 +500,14 @@ class TextEditingDeltaState { | |||
| // we calculate the length of the deleted text by comparing the new and old editing state lengths. | |||
| // This value is then subtracted from the end position of the delta to capture the deleted range. | |||
There was a problem hiding this comment.
These comments might also need some updating.
| @@ -497,7 +500,14 @@ class TextEditingDeltaState { | |||
| // we calculate the length of the deleted text by comparing the new and old editing state lengths. | |||
| // This value is then subtracted from the end position of the delta to capture the deleted range. | |||
| final int deletedLength = newTextEditingDeltaState.oldText.length - newEditingState.text!.length; | |||
| newTextEditingDeltaState.deltaStart = newTextEditingDeltaState.deltaEnd - deletedLength; | |||
| final bool backwardDeletion = newEditingState.baseOffset != lastEditingState?.baseOffset; | |||
There was a problem hiding this comment.
This seems fine to me, though I wonder if RTL affects this at all.
bleroux
force-pushed
the
fix_editing_delta_is_wrong_for_deletion
branch
from
5ce5b5d to
5016d99
Compare
bleroux
force-pushed
the
fix_editing_delta_is_wrong_for_deletion
branch
from
5016d99 to
7cd2dd5
Compare
|
@bleroux @Renzo-Olivares |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, hitting the delete key causes
DeltaTextInputClientto send incorrect delta on Web platform.Related Issue
Fixes flutter/flutter#112920
Fixes flutter/samples#1424
Tests
Updates 1 test.
Adds 2 tests.