Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] Support access the descriptor of PipelineFuture directly #37415

Merged
merged 6 commits into from
Nov 10, 2022
Merged

[Impeller] Support access the descriptor of PipelineFuture directly #37415

merged 6 commits into from
Nov 10, 2022

Conversation

ColdPaleLight
Copy link
Member

fix flutter/flutter#98684

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@ColdPaleLight ColdPaleLight marked this pull request as draft November 8, 2022 09:30
@ColdPaleLight ColdPaleLight self-assigned this Nov 8, 2022
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@ColdPaleLight ColdPaleLight marked this pull request as ready for review November 8, 2022 13:06
chinmaygarde
chinmaygarde approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! This was on my radar for quite a while.

@ColdPaleLight ColdPaleLight added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 9, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 10, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 10, 2022

auto label is removed for flutter/engine, pr: 37415, due to - The status or check suite Mac Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@ColdPaleLight
Copy link
Member Author

ColdPaleLight commented Nov 10, 2022 •
edited
Loading

@chinmaygarde Some tests failed, I tried looking for the root cause but couldn't find it. I also can't reproduce it locally. Would you mind taking a look when you have a chance? Not in a hurry. Thanks!

@chinmaygarde chinmaygarde mentioned this pull request Nov 10, 2022
Closed
@chinmaygarde
Copy link
Member

@ColdPaleLight I don't think this is related to your patch. We've been seeing curious errors like this and are tracking in flutter/flutter#114872. I'll re-run the job and land if it fails again. Will elevate priority of the linked bug in the morning.

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 10, 2022
@ColdPaleLight ColdPaleLight added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Nov 10, 2022
@auto-submit auto-submit bot merged commit a71c0c6 into flutter:main Nov 10, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2022
@engine-flutter-autoroll
a71c0c6c3 [Impeller] Support access the descriptor of PipelineFuture …
c49b317 
…directly (flutter/engine#37415)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 10, 2022
@engine-flutter-autoroll
a71c0c6c3 [Impeller] Support access the descriptor of PipelineFuture …
c7d1154 
…directly (flutter/engine#37415) (#115063)
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Nov 10, 2022
flutter: a71c0c6c3 [Impeller] Support access the descriptor of Pipeli…
70c78a3 
…neFuture directly (flutter/engine#37415) (#115063)

Commit: c7d11549a51eb37807604bdfd1141a82be8fac4b
This was referenced Nov 10, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 10, 2022
@engine-flutter-autoroll
c7d1154 a71c0c6c3 [Impeller] Support access the descriptor of Pipelin…
eacf662 
…eFuture directly (flutter/engine#37415) (flutter/flutter#115063)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2022
@engine-flutter-autoroll
c7d1154 a71c0c6c3 [Impeller] Support access the descriptor of Pipelin…
900f8fe 
…eFuture directly (flutter/engine#37415) (flutter/flutter#115063)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Nov 10, 2022
@engine-flutter-autoroll
Roll Flutter from d3dcd7d to c7d1154 (13 revisions) (#6689)
f35c169 
* 3a656b1 Add more supported simulator debugging options and improve tests (flutter/flutter#114628)

* 51c517c [flutter_tools/dap] Add support for forwarding `flutter run --machine` exposeUrl requests to the DAP client (flutter/flutter#114539)

* 8e5439c Roll Flutter Engine from e7d7edab98ad to c76035429c36 (14 revisions) (flutter/flutter#115008)

* a479718 Update cirrus key (flutter/flutter#115006)

* dccc761 Roll Flutter Engine from c76035429c36 to aa4b3ea2f733 (27 revisions) (flutter/flutter#115025)

* d0491dc Add the `channel` parameter to the Dartpad samples (flutter/flutter#115018)

* befd8b6 722414a26 Implemented threadsafe platform channel replies on windows (flutter/engine#36909) (flutter/flutter#115033)

* 154ae0f `updateSemantics` in TestWindow should always be implemented. (flutter/flutter#114857)

* 008ac17 remove unnecessary brace in string interpolation (flutter/flutter#115032)

* 8926d9e a9fbf6af5 Roll Fuchsia Linux SDK from mDzQK4ZUk_Y4wfZa_... to RNSA2Wp1MObtc7OHy... (flutter/engine#37485) (flutter/flutter#115045)

* e6fb124 Roll Flutter Engine from a9fbf6af52c9 to b42ed6933cef (2 revisions) (flutter/flutter#115048)

* ff75451 a42b2d9b9 Fix a race in the EmbedderA11yTest.A11yTreeIsConsistent tests (flutter/engine#37488) (flutter/flutter#115060)

* c7d1154 a71c0c6c3 [Impeller] Support access the descriptor of PipelineFuture directly (flutter/engine#37415) (flutter/flutter#115063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2022
@engine-flutter-autoroll
c7d1154 a71c0c6c3 [Impeller] Support access the descriptor of Pipelin…
df1b706 
…eFuture directly (flutter/engine#37415) (flutter/flutter#115063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2022
@engine-flutter-autoroll
c7d1154 a71c0c6c3 [Impeller] Support access the descriptor of Pipelin…
908916a 
…eFuture directly (flutter/engine#37415) (flutter/flutter#115063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2022
@engine-flutter-autoroll
c7d1154 a71c0c6c3 [Impeller] Support access the descriptor of Pipelin…
90cfd9e 
…eFuture directly (flutter/engine#37415) (flutter/flutter#115063)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2022
@engine-flutter-autoroll
c7d1154 a71c0c6c3 [Impeller] Support access the descriptor of Pipelin…
eb3d7d3 
…eFuture directly (flutter/engine#37415) (flutter/flutter#115063)
IVLIVS-III pushed a commit to IVLIVS-III/flutter_plugins_fork that referenced this pull request Nov 11, 2022
@engine-flutter-autoroll @IVLIVS-III
Roll Flutter from d3dcd7d to c7d1154 (13 revisions) (flutter#6689)
bcb27f2 
* 3a656b1 Add more supported simulator debugging options and improve tests (flutter/flutter#114628)

* 51c517c [flutter_tools/dap] Add support for forwarding `flutter run --machine` exposeUrl requests to the DAP client (flutter/flutter#114539)

* 8e5439c Roll Flutter Engine from e7d7edab98ad to c76035429c36 (14 revisions) (flutter/flutter#115008)

* a479718 Update cirrus key (flutter/flutter#115006)

* dccc761 Roll Flutter Engine from c76035429c36 to aa4b3ea2f733 (27 revisions) (flutter/flutter#115025)

* d0491dc Add the `channel` parameter to the Dartpad samples (flutter/flutter#115018)

* befd8b6 722414a26 Implemented threadsafe platform channel replies on windows (flutter/engine#36909) (flutter/flutter#115033)

* 154ae0f `updateSemantics` in TestWindow should always be implemented. (flutter/flutter#114857)

* 008ac17 remove unnecessary brace in string interpolation (flutter/flutter#115032)

* 8926d9e a9fbf6af5 Roll Fuchsia Linux SDK from mDzQK4ZUk_Y4wfZa_... to RNSA2Wp1MObtc7OHy... (flutter/engine#37485) (flutter/flutter#115045)

* e6fb124 Roll Flutter Engine from a9fbf6af52c9 to b42ed6933cef (2 revisions) (flutter/flutter#115048)

* ff75451 a42b2d9b9 Fix a race in the EmbedderA11yTest.A11yTreeIsConsistent tests (flutter/engine#37488) (flutter/flutter#115060)

* c7d1154 a71c0c6c3 [Impeller] Support access the descriptor of PipelineFuture directly (flutter/engine#37415) (flutter/flutter#115063)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
@ColdPaleLight @schwa423
[Impeller] Support access the descriptor of PipelineFuture directly (f…
48a5002 
…lutter#37415)

* [Impeller] Support access the descriptor of PipelineFuture directly

* Tweak code

* Clean code
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
@engine-flutter-autoroll
Roll Flutter from d3dcd7d to c7d1154 (13 revisions) (flutter#6689)
6e870d3 
* 3a656b1 Add more supported simulator debugging options and improve tests (flutter/flutter#114628)

* 51c517c [flutter_tools/dap] Add support for forwarding `flutter run --machine` exposeUrl requests to the DAP client (flutter/flutter#114539)

* 8e5439c Roll Flutter Engine from e7d7edab98ad to c76035429c36 (14 revisions) (flutter/flutter#115008)

* a479718 Update cirrus key (flutter/flutter#115006)

* dccc761 Roll Flutter Engine from c76035429c36 to aa4b3ea2f733 (27 revisions) (flutter/flutter#115025)

* d0491dc Add the `channel` parameter to the Dartpad samples (flutter/flutter#115018)

* befd8b6 722414a26 Implemented threadsafe platform channel replies on windows (flutter/engine#36909) (flutter/flutter#115033)

* 154ae0f `updateSemantics` in TestWindow should always be implemented. (flutter/flutter#114857)

* 008ac17 remove unnecessary brace in string interpolation (flutter/flutter#115032)

* 8926d9e a9fbf6af5 Roll Fuchsia Linux SDK from mDzQK4ZUk_Y4wfZa_... to RNSA2Wp1MObtc7OHy... (flutter/engine#37485) (flutter/flutter#115045)

* e6fb124 Roll Flutter Engine from a9fbf6af52c9 to b42ed6933cef (2 revisions) (flutter/flutter#115048)

* ff75451 a42b2d9b9 Fix a race in the EmbedderA11yTest.A11yTreeIsConsistent tests (flutter/engine#37488) (flutter/flutter#115060)

* c7d1154 a71c0c6c3 [Impeller] Support access the descriptor of PipelineFuture directly (flutter/engine#37415) (flutter/flutter#115063)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
a71c0c6c3 [Impeller] Support access the descriptor of PipelineFuture …
d928316 
…directly (flutter/engine#37415) (flutter#115063)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
a71c0c6c3 [Impeller] Support access the descriptor of PipelineFuture …
59cc18a 
…directly (flutter/engine#37415) (flutter#115063)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from d3dcd7d to c7d1154 (13 revisions) (flutter#6689)
04d5ea0 
* 3a656b1 Add more supported simulator debugging options and improve tests (flutter/flutter#114628)

* 51c517c [flutter_tools/dap] Add support for forwarding `flutter run --machine` exposeUrl requests to the DAP client (flutter/flutter#114539)

* 8e5439c Roll Flutter Engine from e7d7edab98ad to c76035429c36 (14 revisions) (flutter/flutter#115008)

* a479718 Update cirrus key (flutter/flutter#115006)

* dccc761 Roll Flutter Engine from c76035429c36 to aa4b3ea2f733 (27 revisions) (flutter/flutter#115025)

* d0491dc Add the `channel` parameter to the Dartpad samples (flutter/flutter#115018)

* befd8b6 722414a26 Implemented threadsafe platform channel replies on windows (flutter/engine#36909) (flutter/flutter#115033)

* 154ae0f `updateSemantics` in TestWindow should always be implemented. (flutter/flutter#114857)

* 008ac17 remove unnecessary brace in string interpolation (flutter/flutter#115032)

* 8926d9e a9fbf6af5 Roll Fuchsia Linux SDK from mDzQK4ZUk_Y4wfZa_... to RNSA2Wp1MObtc7OHy... (flutter/engine#37485) (flutter/flutter#115045)

* e6fb124 Roll Flutter Engine from a9fbf6af52c9 to b42ed6933cef (2 revisions) (flutter/flutter#115048)

* ff75451 a42b2d9b9 Fix a race in the EmbedderA11yTest.A11yTreeIsConsistent tests (flutter/engine#37488) (flutter/flutter#115060)

* c7d1154 a71c0c6c3 [Impeller] Support access the descriptor of PipelineFuture directly (flutter/engine#37415) (flutter/flutter#115063)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees

@ColdPaleLight ColdPaleLight

Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Impeller] PipelineFuture forces a pessimization if all the caller needs to do is access the descriptor.
2 participants
@ColdPaleLight @chinmaygarde