This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[Embedder API] Introduce new semantics update callback and migrate Windows" #37487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3d9f485.
flutter-dashboard
bot
added
embedder
Contributor
Author
|
See also a potential fix for the race condition: #37488 |
Contributor
Author
|
It looks like a fix (#37488) is making this revert obsolete. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #37129
The unit test in this PR has been causing timeouts on some of the testing bots. See here: https://ci.chromium.org/p/flutter/builders/try/Mac%20Host%20Engine
@jason-simmons suggests that the latches might be the problem and perhaps a countdown might work better...