-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Eliminate macOS 10.14 availability check #37490
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
test-exempt: removing code |
Now that the macOS embedders have all been updated to use a minimum macOS SDK of 10.14, eliminate the remaining @available checks dependent on that version. Issue: flutter/flutter#114445
Nice. I think this means we can remove an ANGLE/Vulkan work around as well... |
In //flutter/vulkan/procs/vulkan_interface.h we can remove lines 27-33 |
And there's another macOS 10.14 check in |
Thanks! The first pass at this did a removal of the Vulcan undef but looked like it may have triggered a segfault in the impeller mac tests, so reverted that file. Will take another look shortly.
|
…115122) * ad89f6ab2 [macOS] Eliminate macOS 10.14 availability check (flutter/engine#37490) * 30e2cedfa chore: fix Dart SDK DEPS file link in DEPS (flutter/engine#37496)
Now that the macOS embedders have all been updated to use a minimum macOS SDK of 10.14, eliminate the remaining @available checks dependent on that version. Issue: flutter/flutter#114445
…lutter#115122) * ad89f6ab2 [macOS] Eliminate macOS 10.14 availability check (flutter/engine#37490) * 30e2cedfa chore: fix Dart SDK DEPS file link in DEPS (flutter/engine#37496)
…lutter#115122) * ad89f6ab2 [macOS] Eliminate macOS 10.14 availability check (flutter/engine#37490) * 30e2cedfa chore: fix Dart SDK DEPS file link in DEPS (flutter/engine#37496)
Now that the macOS embedders have all been updated to use a minimum macOS SDK of 10.14, eliminate the remaining
@available
checks dependent on that version.This is one in a series of post-10.14 cleanup patches.
No tests are added since the code removed was a workaround for macOS 10.13. We now build with both a minimum SDK and deployment target of 10.14, and as such the workaround was already disabled at compile-time, making this change effectively a no-op.
Issue: flutter/flutter#114445
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.