[macOS] Merge FlutterSurfaceManager classes #37701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
force-pushed
the
merge-surface-manager
branch
from
6b5a29c to
a7b3128
Compare
cbracken
changed the title
iskakaushik
approved these changes
Nov 17, 2022
cbracken
force-pushed
the
merge-surface-manager
branch
3 times, most recently
from
ccba787 to
7aeb7be
Compare
Previously, FlutterSurfaceManager was a protocol with two concrete implementations: FlutterGLSurfaceManager and FlutterMetalSurfaceManager. Most of the implementation was in a shared superclass, FlutterIOSurfaceManager, which called into the OpenGL or Metal-specific subclass when backend-specific operations (such as allocating textures) was required. It did so via a delegate pattern, wherein the subclasses both implemented the FlutterIOSurfaceManagerDelegate protocol that exposed the backend-specific functionality. Now that only the Metal implementation remains, the delegate code can be inlined into the calling functions, and the class hierarchy can be squashed into a single concrete implementation class, FlutterSurfaceManager, similar to how it was originally implemented in flutter#21525 before we had two backends. Issue: flutter/flutter#108304 Issue: flutter/flutter#114445
cbracken
force-pushed
the
merge-surface-manager
branch
from
7aeb7be to
65061e6
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 17, 2022
…115589) * 556e0415a Revert "[Impeller] Reland: Refactor color source resolution to use explicit factory types (#37677)" (flutter/engine#37720) * 5b31f4f0d Reland layer state stack 2 (flutter/engine#37394) * d955a72c5 [macOS] Merge FlutterSurfaceManager and impls (flutter/engine#37701)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115589) * 556e0415a Revert "[Impeller] Reland: Refactor color source resolution to use explicit factory types (flutter#37677)" (flutter/engine#37720) * 5b31f4f0d Reland layer state stack 2 (flutter/engine#37394) * d955a72c5 [macOS] Merge FlutterSurfaceManager and impls (flutter/engine#37701)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115589) * 556e0415a Revert "[Impeller] Reland: Refactor color source resolution to use explicit factory types (flutter#37677)" (flutter/engine#37720) * 5b31f4f0d Reland layer state stack 2 (flutter/engine#37394) * d955a72c5 [macOS] Merge FlutterSurfaceManager and impls (flutter/engine#37701)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
FlutterSurfaceManagerwas a protocol with two concrete implementations:FlutterGLSurfaceManagerandFlutterMetalSurfaceManager. Most of the implementation was in a shared superclass,FlutterIOSurfaceManager, which called into the OpenGL or Metal-specific subclass when backend-specific operations (such as allocating textures) was required. It did so via a delegate pattern, wherein the subclasses both implemented theFlutterIOSurfaceManagerDelegateprotocol that exposed the backend-specific functionality.Now that only the Metal implementation remains, the delegate code can be inlined into the calling functions, and the class hierarchy can be squashed into a single concrete implementation class,
FlutterSurfaceManager, similar to how it was originally implemented in #21525 before we had two backends.Issue: flutter/flutter#108304
Issue: flutter/flutter#114445
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.