Full implementation of text-input-test

[lin-erik]

This PR connects the text-input-view with text-input-test.cc

• Remove text-input-realm and substitute it with an RealmBuilder environment
• text-input-view doesn't implement a TextField that displays text, it currently only validates that we are receiving through onPlatformMessage and sending back the correct keystrokes

[skia-gold]

Gold has detected about 72 new digest(s) on patchset 6.
View them at https://flutter-engine-gold.skia.org/cl/github/37986

[akbiggs]

Nice. @filmil FYI this sets up an integration test for text input in Flutter Engine. Because we can't depend on the Flutter Framework directly in the Engine repo, there are some changes in the approach: instead of creating a text input widget and checking that it receives the input, we just check in the Dart component that the platform message for keyevents looks like what we expect it to.

[akbiggs]

So just confirming, the test will fail if it doesn't receive the correct platform message, I guess because this will time out?

Just want to make sure it won't pass if the platform message doesn't get sent.

[lin-erik]

Yep, it'll hang + the test won't receive an expected output so it'll fail (see L101 in text-input-test.cc for the matching logic for received vs expected)

[akbiggs]

Should we also have a test for the flutter/textinput channel? My impression was that we send messages along both flutter/keyevent and flutter/textinput.

[lin-erik]

I don't see messages being sent through flutter/textinput, just flutter/keyevent.. I wonder if only TextField sends through the flutter/textinput channel and flutter/keyevent is for keys pressed anywhere

Here's some sample logs from the test:

[00331.442776][flutter_jit_runner] INFO: text-input-view.cm(flutter): received flutter/keyevent platform message: {type: keydown, keymap: fuchsia, hidUsage: 458770, codePoint: 111, modifiers: 0}
[00331.442786][flutter_jit_runner] INFO: text-input-view.cm(flutter): text-input-view reporting keyboard input to KeyboardInputListener
[00331.543676][flutter_jit_runner] INFO: text-input-view.cm(flutter): received flutter/keyevent platform message: {type: keyup, keymap: fuchsia, hidUsage: 458770, codePoint: 111, modifiers: 0}

[filmil]

Yay!

…

On Mon, Dec 5, 2022 at 1:30 PM Alexander Biggs ***@***.***> wrote: ***@***.**** approved this pull request. Nice. @filmil <https://github.com/filmil> FYI this sets up an integration test for text input in Flutter Engine. Because we can't depend on the Flutter Framework directly in the Engine repo, there are some changes in the approach: instead of creating a text input widget and checking that it receives the input, we just check in the Dart component that the platform message for keyevents looks like what we expect it to. ------------------------------ In shell/platform/fuchsia/flutter/tests/integration/text-input/text-input-view/lib/text_input_view.dart <#37986 (comment)>: > + final recorder = PictureRecorder(); + final canvas = Canvas(recorder, physicalBounds); + canvas.scale(pixelRatio, pixelRatio); + // Draw something + final paint = Paint()..color = this._backgroundColor; + canvas.drawRect(windowBounds, paint); + // Build the scene + final picture = recorder.endRecording(); + final sceneBuilder = SceneBuilder() + ..pushClipRect(physicalBounds) + ..addPicture(Offset.zero, picture) + ..pop(); + window.render(sceneBuilder.build()); + } + + void platformMessage(String name, ByteData data) async { Is there another name we can pick for this method? I'm not sure what it does from the name. ------------------------------ In shell/platform/fuchsia/flutter/tests/integration/text-input/text-input-view/lib/text_input_view.dart <#37986 (comment)>: > + print('received ${name} platform message: ${decodedJson}'); + + if (name == "flutter/keyevent" && decodedJson["type"] == "keydown") { + if (hidToKey[decodedJson["hidUsage"]] != null) { + await _respond(test_text.KeyboardInputListenerReportTextInputRequest( + text: hidToKey[decodedJson["hidUsage"]], + )); + } + } + + window.scheduleFrame(); + } + + void _respond(test_text.KeyboardInputListenerReportTextInputRequest request) async { + print('text-input-view reporting keyboard input to KeyboardInputListener'); + await _responseListener.reportTextInput(request); So just confirming, the test will fail if it doesn't receive the correct platform message, I guess because this will time out? Just want to make sure it won't pass if the platform message doesn't get sent. ------------------------------ In shell/platform/fuchsia/flutter/tests/integration/text-input/text-input-view/lib/text_input_view.dart <#37986 (comment)>: > + final picture = recorder.endRecording(); + final sceneBuilder = SceneBuilder() + ..pushClipRect(physicalBounds) + ..addPicture(Offset.zero, picture) + ..pop(); + window.render(sceneBuilder.build()); + } + + void platformMessage(String name, ByteData data) async { + final buffer = data.buffer; + var list = buffer.asUint8List(data.offsetInBytes, data.lengthInBytes); + var decoded = utf8.decode(list); + var decodedJson = json.decode(decoded); + print('received ${name} platform message: ${decodedJson}'); + + if (name == "flutter/keyevent" && decodedJson["type"] == "keydown") { Should we also have a test for the flutter/textinput channel? My impression was that we send messages along both flutter/keyevent and flutter/textinput. — Reply to this email directly, view it on GitHub <#37986 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB4GMDWKISXTMIOS5Z7PWDWLZNIVANCNFSM6AAAAAASP52JYA> . You are receiving this because you were mentioned.Message ID: ***@***.***>