Roll Dart SDK from 35a9facce191 to e517487c5679 (Dart 3.0)

[a-siva]

https://dart.googlesource.com/sdk.git/+log/35a9facce191..e517487c5679

2022-12-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-0.0.dev

[zanderso]

Looks like the dependency on package:quiver needs to be updated. google/quiver-dart@c855b10 is 3.1.0 and has been migrated to null-safety.

[zanderso]

Unfortunately, it also looks like the generated FIDL bindings are not ready for sound null-safety? It might be simpler to pass --no-sound-null-safety to the VM in the flutter_runner and/or dart_runner. I'm not sure where to do that, but maybe it's here? https://github.com/flutter/engine/blob/main/shell/platform/fuchsia/flutter/component_v1.cc#L426

cc @akbiggs for advice.

[zanderso]

I don't know whether this also needs to go in https://github.com/flutter/engine/blob/main/shell/platform/fuchsia/flutter/component_v2.cc#L489. I was hoping to get some help from the Fuchsia team on that. But if the presubmits are green, I think we can go ahead with this as-is, and follow-up with them after.

[a-siva]

Let me update the version of Dart now and see if the tests succeed.

[akbiggs]

Sorry, I forgot to hit post on my reply. We do need to update component_v2 for Flutter https://github.com/flutter/engine/blob/main/shell/platform/fuchsia/flutter/component_v2.cc#L489 as well as the Dart runner https://github.com/flutter/engine/blob/main/shell/platform/fuchsia/dart_runner/dart_runner.cc#L210

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.