-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] Remove dependency on 'profiling' subfolder of canvaskit. #38169
Merged
harryterkelsen
merged 6 commits into
flutter:main
from
harryterkelsen:remove-canvaskit-profiling-extra
Jan 24, 2023
Merged
[web] Remove dependency on 'profiling' subfolder of canvaskit. #38169
harryterkelsen
merged 6 commits into
flutter:main
from
harryterkelsen:remove-canvaskit-profiling-extra
Jan 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyebrowsoffire
approved these changes
Dec 9, 2022
mdebbar
approved these changes
Dec 12, 2022
yjbanov
reviewed
Dec 21, 2022
yjbanov
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 25, 2023
…119090) * acb561092 [web] Remove dependency on 'profiling' subfolder of canvaskit. (flutter/engine#38169) * d98926c32 [Impeller] Add and reorder FAQ entries. (flutter/engine#39106)
ricardoamador
pushed a commit
to ricardoamador/engine
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the dependency on the
profiling/
subdirectory in the CanvasKit directory. There are several reasons to do this:wasm_profile
orwasm_debug
and use that as your local engine.Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.