Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Remove dependency on 'profiling' subfolder of canvaskit. #38169

Merged

Conversation

harryterkelsen
Copy link
Contributor

Removes the dependency on the profiling/ subdirectory in the CanvasKit directory. There are several reasons to do this:

  1. Crashes from CanvasKit should be very rare. In the rare case that someone crashes the CanvasKit module and gets a stacktrace from WASM, it is even rarer that the unobfuscated stacktrace would allow them to debug and fix the problem.
  2. If the profile build of CanvasKit is actually required, you can still build wasm_profile or wasm_debug and use that as your local engine.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Dec 9, 2022
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harryterkelsen harryterkelsen merged commit acb5610 into flutter:main Jan 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 25, 2023
…119090)

* acb561092 [web] Remove dependency on 'profiling' subfolder of canvaskit. (flutter/engine#38169)

* d98926c32 [Impeller] Add and reorder FAQ entries. (flutter/engine#39106)
ricardoamador pushed a commit to ricardoamador/engine that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants