Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Make AccessibilityBridge a AXPlatformTreeManager #38610

Merged
merged 5 commits into from
Jan 3, 2023
Merged

Make AccessibilityBridge a AXPlatformTreeManager #38610

merged 5 commits into from
Jan 3, 2023

Conversation

@yaakovschectman
Copy link
Contributor

@yaakovschectman yaakovschectman commented Jan 3, 2023

For UIA implementation, we must have an AXPlatformTreeManager to manage the trees of platform nodes. the AccessibilityBridge already serves a similar purpose.

Part of flutter/flutter#116219

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@yaakovschectman yaakovschectman self-assigned this Jan 3, 2023
@yaakovschectman yaakovschectman marked this pull request as ready for review January 3, 2023 15:40
loic-sharma
loic-sharma reviewed Jan 3, 2023
View reviewed changes
shell/platform/common/accessibility_bridge.cc Outdated
const ui::AXNode::AXID node_id) const {
auto platform_delegate_weak = GetFlutterPlatformNodeDelegateFromID(node_id);
if (platform_delegate_weak.expired()) {
return nullptr;
Copy link
Member

@loic-sharma loic-sharma Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this case unnecessary due to lock check below? See: https://en.cppreference.com/w/cpp/memory/weak_ptr/lock

Copy link
Contributor Author

@yaakovschectman yaakovschectman Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably

@yaakovschectman yaakovschectman merged commit c0b3f8f into flutter:main Jan 3, 2023
@yaakovschectman yaakovschectman deleted the uiatext_treeman branch January 3, 2023 20:18
This was referenced Jan 3, 2023
Merged
Closed
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cbracken cbracken Awaiting requested review from cbracken

@chunhtai chunhtai Awaiting requested review from chunhtai

@a-wallen a-wallen Awaiting requested review from a-wallen

@dkwingsmt dkwingsmt Awaiting requested review from dkwingsmt

1 more reviewer

@loic-sharma loic-sharma loic-sharma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yaakovschectman yaakovschectman

Labels

accessibility affects: desktop platform-windows

Projects

Flutter Desktop
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yaakovschectman @loic-sharma