This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Bump versions #391
Merged
Bump versions #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
bungeman
pushed a commit
to bungeman/engine
that referenced
this pull request
Nov 16, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
* web-angular-*: update to angular 3.0.0, etc * Renamed `angular2_components` to `angular_components` * web-angular-*: update <base href> init script
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
This will make it easier to define custom test platforms (both via flutter#391 and flutter#99) in the future. Because those platforms will be loaded based on the configuration, requiring knowledge of them to parse the user's platform arguments would produce an unresolvable circular dependency.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
We want users to be able to dynamically define new platforms, which means we need infrastructure in place for piping those platforms to places that previously assumed TestPlatform.all was a full list of available platforms. PlatformSelector is the trickiest example, since it's parsed in a number of different places and needs to provide useful feedback to users when they use an undefined platform. This splits parsing and platform validation into two separate steps. Validation will be done immediately after parsing when the selectors come from top-level annotations or parameters passed to test() or group(), but selectors defined in configuration files are now parsed only after all configuration is parsed. This will allow new platforms to be defined *and* referenced in configuration files. See flutter#99 See flutter#391
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
This ensures that the remote listener has access to any platforms that are dynamically loaded in the test runner, so they can be used in platform selectors. See flutter#99 See flutter#391
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Now that the Loader is the canonical place for determining which TestPlatforms are valid, we no longer need a separate mechanism for registering platforms. Adding a plugin to the loader is sufficient. See flutter#391
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
This doesn't really do anything yet, since no platforms currently support customization. See flutter#391
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Add the ability to define and override test platforms See flutter#99 Closes flutter#391
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.