[Impeller] partially remove remap sampler support #39147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
changed the title
|
I could also fixup the location data in the generated IPLR file but I'm unusure if we're using it for anything else. |
iskakaushik
reviewed
Jan 26, 2023
| @@ -210,6 +207,36 @@ bool RuntimeEffectContents::Render(const ContentContext& renderer, | |||
| } | |||
| } | |||
|
|
|||
| size_t sampler_index = 0; | |||
| FML_DCHECK(minimum_sampler_index >= 0); | |||
There was a problem hiding this comment.
wouldn't this always be true? Given that the type is size_t
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 39147, due to - The status or check suite Linux Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
zanderso
reviewed
Jan 26, 2023
| @@ -332,34 +332,6 @@ void main() async { | |||
| shader.dispose(); | |||
| }); | |||
|
|
|||
| // This test can't rely on actual pixels rendered since it needs to run on a | |||
There was a problem hiding this comment.
Is the test on line 275 sufficient? Does that test need to have a sampler or two thrown in?
There was a problem hiding this comment.
wouldn't apply either way, its not running on impeller or metal?
iskakaushik
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 26, 2023
…119279) * 99270b81c Roll Fuchsia Mac SDK from _H53AyDxR9Pm2TbwN... to KLzrg8eFD9m5J9xa-... (flutter/engine#39155) * 9c20d2afb Roll Fuchsia Linux SDK from pGX7tanT1okL8XCg-... to ggI4a2jNo5aj6Rp6w... (flutter/engine#39157) * 664e7d3ae Roll Skia from 3d0e2ad41911 to 0e1cb7bc43dc (1 revision) (flutter/engine#39156) * ca38bb2e6 Roll Skia from 0e1cb7bc43dc to 5e363a69efbe (3 revisions) (flutter/engine#39158) * ce3bfa124 Roll Dart SDK from f61211592196 to 160774c04493 (2 revisions) (flutter/engine#39159) * 36cb5c8ce Roll Dart SDK from 160774c04493 to 5a8b34f040f5 (1 revision) (flutter/engine#39160) * ba188d7ca Update infrastructure python code to be compatible with python 2 and python 3 (flutter/engine#39133) * 8baff3e90 Roll Skia from 5e363a69efbe to ad7955820dc6 (2 revisions) (flutter/engine#39161) * ed9fc3610 Roll Skia from ad7955820dc6 to e9ac244d61b2 (6 revisions) (flutter/engine#39165) * cb6df8585 Roll Dart SDK from 5a8b34f040f5 to 4a8615b7e3ed (1 revision) (flutter/engine#39167) * d85ec02b0 [fuchsia] Migrate to new RealmBuilder API (flutter/engine#39163) * 939012600 [Impeller] partially remove remap sampler support (flutter/engine#39147)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#119173. The runtime IPLR contains all of the infromation to handle samplers without remaping. Its just a bit awkward to use at this point.
As a follow up will make location data take into account this offset and delete the flag (after rolling into tool).
Separately, we should investigate if enabling vulkan regressed any other functionality on macOS.