Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[impellerc] remove remaining remap sampler support #39198

Merged
merged 1 commit into from
Jan 27, 2023
Merged

[impellerc] remove remaining remap sampler support #39198

merged 1 commit into from
Jan 27, 2023

Conversation

jonahwilliams
Copy link
Member

Usage removed in flutter/flutter#119346

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams
Copy link
Member Author

I don't believe I need a test exception because this is a delete-only PR

@zanderso
Copy link
Member

I don't believe I need a test exception because this is a delete-only PR

Is this a bug in the bot?

@jonahwilliams
Copy link
Member Author

bug and/or limitation 😄

@zanderso
Copy link
Member

Removing the flag from building the shaders for the text fixture is also updating the test.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 27, 2023
@auto-submit auto-submit bot merged commit 4bab184 into flutter:main Jan 27, 2023
@jonahwilliams jonahwilliams deleted the remove_remap branch January 27, 2023 19:05
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 27, 2023
@engine-flutter-autoroll
4bab18407 [impellerc] remove remaining remap sampler support (flutter…
9c011b4 
…/engine#39198)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 27, 2023
@engine-flutter-autoroll
Roll Flutter Engine from b32fc7fef208 to 8567d96993ed (5 revisions) (#…
ab2232a 
…119369)

* ab1eda7c7 Handle proto deps that were added to the Dart SDK (flutter/engine#39098)

* 70f96af0a [impellerc] remove coffset usage (flutter/engine#39199)

* 4bab18407 [impellerc] remove remaining remap sampler support (flutter/engine#39198)

* a1e657a1e Move Linux Fuchsia FEMU to bringup due to flakes (flutter/engine#39202)

* 8567d9699 [Impeller] support overlapping stops with SSBO gradients. (flutter/engine#39174)
@zanderso zanderso mentioned this pull request Jan 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonahwilliams @zanderso