Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@XilaiZhang
Copy link
Contributor

@XilaiZhang XilaiZhang commented Jan 31, 2023

TLDR: this fixes the breakages in the web engine build. such as https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Web%20Engine/15016/overview

long story:
Web failure
We are trying to land 8 engine cherry picks, but linux web engine was failing on the release branches with a deprecation warning
Casey pointed me to Zach on post submit failures. Zach added me to flutter web channel, and connected me with Yegor.
At first the error was thought to be a flake or a recipe version mismatch. Examining build history and recipe versions were fruitless.
The cherry picked engine pr doesn’t relate to the web failure, so initially the failure was suspected to be caused by dart changes on the release branch. And Zach connected us with Siva. we examined dart commits between dart main -> dev -> beta -> stable, and didn’t find any culprit.
In the mean time, Jackson proposed a fix PR #39269 and pointed to Sam’s change dart-lang/sdk@b1525bc. However, this idea was initially turned down because people believe the newest changes in dart should not make it into the flutter release branch
However, Yegor later pointed out that dart pub get would pick up an unpinned version of the meta package. in https://github.com/flutter/engine/blob/main/lib/web_ui/pubspec.yaml web ui picks up the newest meta package. And it was probably what happened in https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8790504714907691905/+/u/web_engine_analysis/stdout
The understandings brought us back to the solution of Jackson’s pr, and a fix forward on head, and then a cherry pick was deemed to be the solution.
It turned out that this failure was the same failure that caused the engine tree to be closed. And luci-broken blocked the fix. Godofredo helped with adding the label “warning: land on red to fix tree breakage”. And merged it into head.
I cherry picked it to stable branch.
Thanks Jackson, Yegor, Zach, Siva, Casey, Godofredo for the help!

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Jan 31, 2023
@XilaiZhang XilaiZhang merged commit b37e2c4 into flutter:flutter-3.7-candidate.1 Jan 31, 2023
@XilaiZhang XilaiZhang deleted the flutter-3.7-candidate.1 branch January 31, 2023 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants