This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add SkSurface include to every file where it's used #39304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
embedder
jason-simmons
approved these changes
Feb 1, 2023
bdero
added
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 1, 2023
…119675) * 7d063fd28 Roll Dart SDK from 9bcc1773ebf0 to 8b57d23a7246 (1 revision) (flutter/engine#39303) * 38913c548 Add SkSurface include to every file where it's used (flutter/engine#39304)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #39295, which just includes
SkSurfacein every file where it's used to ensure the Skia roll gets unblocked. To save time, I didn't normalize the includes based on header dependencies.Blocked Skia roll: #39299