[Impeller] use IPSampleDecal in advanced blends. #39523
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
changed the title
jonahwilliams
force-pushed
the
advanced_blend_spec_2
branch
3 times, most recently
from
4730607 to
4aa04ea
Compare
jonahwilliams
force-pushed
the
advanced_blend_spec_2
branch
from
4aa04ea to
257d12f
Compare
| continue | ||
| result = {} | ||
| result['filename'] = os.path.relpath(shader['filename'], build_gen_dir) | ||
| filename = os.path.relpath(shader['filename'], build_gen_dir) |
There was a problem hiding this comment.
@zanderso I tried to get the paths right with various combinations of relative and absolute paths, plus a few different working directories, but no dice.
This seems like a harmless change though.
There was a problem hiding this comment.
What were shader['filename'] and build_gen_dir here when you ran from a cwd of src/ (that is the directory containing out) ?
There was a problem hiding this comment.
build_gen_dir: out/android_debug_arm64/gen/malioc
filename: ../flutter/impeller/scene/shaders/gles/unskinned.vert.gles
jonahwilliams
added
the
autosubmit
…120928) * 7cf63a03f [Impeller] use IPSampleDecal in advanced blends. (flutter/engine#39523) * 9da851557 Remove extraneous if (flutter/engine#39683) * 6602fc753 [macOS] Implement platform view mutators (flutter/engine#38699)
3 participants
Slightly improves performance and tests malioc on CI