-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Impeller] Ignore the mask filter when saving layer #39583
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
IIRC @bdero added that initially. So he may have additional context. Also cc @jonahwilliams. But otherwise LGTM to match Skia behavior. Is there a reduced test case? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…120781) * 414538fc6 [Impeller] Ignore the mask filter when saving layer (flutter/engine#39583) * ec70b5aa9 Roll Fuchsia Linux SDK from A15Lg2MzGSkbj33mo... to ejOvPyZ4UL2DoQhn6... (flutter/engine#39645)
According to Skia's documentation and implementation, mask filters are ignored for saved layers. So I guess Impeller needs to be consistent with it.
https://github.com/google/skia/blob/main/include/core/SkCanvas.h#L604-L605
https://github.com/google/skia/blob/main/src/core/SkCanvas.cpp#L1114
Pre-launch Checklist
///
).