[Impeller] Implement invert colors flag. #39729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Feb 20, 2023
|
Isn't the before/after swapped? |
|
No, that's the point :) Smart invert inverts the screen except for images/videos. Except that is implemented in UIKit so it inverts the entire flutter screen. So we detect that smart invert is enable and apply an inversion to our own images, so that they appear normal. |
|
🙃 |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 20, 2023
sourcegraph-bot
pushed a commit
to sgtest/megarepo
that referenced
this pull request
Feb 20, 2023
…engine#39729) (#121074) Commit: cc9b198213eba886138b8eada2e2a4a57be50228
This was referenced Feb 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 20, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 20, 2023
* fc8b7c7 4434f3a43 Roll Fuchsia Mac SDK from HtmcMFg6ZlyRkcNsB... to 7FGKB187AdG0SCban... (flutter/engine#39756) (flutter/flutter#121067) * d54d3b4 d00cc4b04 Roll Fuchsia Linux SDK from 7rgqQxifQPjH_2zXB... to 0RfFdaUCok_sFfUN1... (flutter/engine#39758) (flutter/flutter#121068) * c71e479 cf85927ff Rename WindowPadding to ViewPadding (flutter/engine#39737) (flutter/flutter#121069) * cc9b198 780279109 [Impeller] Implement invert colors flag. (flutter/engine#39729) (flutter/flutter#121074) * 8d305b6 5d61f352c Roll Fuchsia Mac SDK from 7FGKB187AdG0SCban... to sXPr06r252ZU681Fi... (flutter/engine#39760) (flutter/flutter#121085) * ae8d051 [M3] Update checkbox shape value (flutter/flutter#120976)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#109739
Before:
After: