Fix imports for FlutterApplication #40100
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| #import "flutter/shell/platform/darwin/macos/framework/Headers/FlutterAppDelegate.h" | ||
| #import "flutter/shell/platform/darwin/macos/framework/Source/FlutterAppDelegate_Internal.h" | ||
| #import "flutter/shell/platform/darwin/macos/framework/Source/FlutterEngine_Internal.h" | ||
|
|
There was a problem hiding this comment.
Ahh, OK. I thought I should separate the C++ from the Objective C headers.
|
test-exempt: Change to import paths to fix Google Testing |
gspencergoog
added
the
autosubmit
Fix imports for FlutterApplication
Description
In #39836, There were some includes that VSCode added that didn't have the correct path, although they do compile in the engine repo, they cause problems when rolled to Google's internal repo because they don't have the correct prefix.
For future archaeologists, the setting to stop clangd from inserting headers that it doesn't really know how to insert properly is: