Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] Make matrix image filters work as expected with nested saving layers #40299

Merged
merged 2 commits into from
Mar 15, 2023
Merged

[Impeller] Make matrix image filters work as expected with nested saving layers #40299

merged 2 commits into from
Mar 15, 2023

Conversation

ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Mar 15, 2023 •
edited
Loading

Fix flutter/flutter#122674

Based on the previous PR #40171 PR fixes the problem of matrix image filter in the nested saving layers scenario.

The matrix we passed to the matrix image filter before is xformation_, which is used to transfer from the local space to the global space. In fact, what we need to pass to the matrix image filter is a matrix that can transfer from the local space to the layer space.

Without the patch

20230314200538_rec_

With the patch

20230314201037_rec_

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@ColdPaleLight ColdPaleLight requested review from chinmaygarde and bdero and removed request for chinmaygarde March 15, 2023 06:43
@ColdPaleLight ColdPaleLight self-assigned this Mar 15, 2023
@ColdPaleLight ColdPaleLight added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 15, 2023
@auto-submit auto-submit bot merged commit dee0ae5 into flutter:main Mar 15, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
dee0ae590 [Impeller] Make matrix image filters work as expected with …
ca2a5fd 
…nested saving layers (flutter/engine#40299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
dee0ae590 [Impeller] Make matrix image filters work as expected with …
86cdc90 
…nested saving layers (flutter/engine#40299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
dee0ae590 [Impeller] Make matrix image filters work as expected with …
e50baf4 
…nested saving layers (flutter/engine#40299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
dee0ae590 [Impeller] Make matrix image filters work as expected with …
64e292f 
…nested saving layers (flutter/engine#40299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
dee0ae590 [Impeller] Make matrix image filters work as expected with …
9fbebba 
…nested saving layers (flutter/engine#40299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
dee0ae590 [Impeller] Make matrix image filters work as expected with …
b4fe886 
…nested saving layers (flutter/engine#40299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
dee0ae590 [Impeller] Make matrix image filters work as expected with …
f28d8f0 
…nested saving layers (flutter/engine#40299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
dee0ae590 [Impeller] Make matrix image filters work as expected with …
947cfef 
…nested saving layers (flutter/engine#40299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
dee0ae590 [Impeller] Make matrix image filters work as expected with …
b00647e 
…nested saving layers (flutter/engine#40299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
dee0ae590 [Impeller] Make matrix image filters work as expected with …
2e7e9fd 
…nested saving layers (flutter/engine#40299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
dee0ae590 [Impeller] Make matrix image filters work as expected with …
5f57282 
…nested saving layers (flutter/engine#40299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
dee0ae590 [Impeller] Make matrix image filters work as expected with …
b774c74 
…nested saving layers (flutter/engine#40299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
dee0ae590 [Impeller] Make matrix image filters work as expected with …
7fc2956 
…nested saving layers (flutter/engine#40299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
dee0ae590 [Impeller] Make matrix image filters work as expected with …
985a5b3 
…nested saving layers (flutter/engine#40299)
zanderso pushed a commit to flutter/flutter that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
Roll Flutter Engine from b7297f025972 to ec151bf2cf72 (12 revisions) (#…
67e5f66 
…122746)

* 3c3cbc738 Manual roll Dart SDK from c766fffb626e to 3b109a04f783 (9 revisions) (flutter/engine#40296)

* dee0ae590 [Impeller] Make matrix image filters work as expected with nested saving layers (flutter/engine#40299)

* 835759f4c Roll Skia from 4d90ba479527 to 3b9131c65c01 (5 revisions) (flutter/engine#40304)

* bbde3a77b Roll Fuchsia Linux SDK from BRE9jdqYpdkbU0j7H... to YaWqKKuj-fAqfpKCm... (flutter/engine#40306)

* 1a7e7c468 Roll Dart SDK from 3b109a04f783 to 5c210933cdfe (2 revisions) (flutter/engine#40307)

* 66a3324cf Analyze more shaders (flutter/engine#40285)

* 405c8513e [Impeller] Improve performance of CupertinoPicker with opacity peephole (flutter/engine#40101)

* 9fc3246bf Reland "Make FlutterTest the default test font" (#40188) (flutter/engine#40245)

* 3ed9f1236 Reland: "Added wide-gamut color support for `ui.Image.toByteData` and `ui.Image.colorSpace`" (flutter/engine#40312)

* e143b309c Bump lower Dart SDK constraints to 3.0 (flutter/engine#40178)

* 086b1a022 [impeller] implement GetPositionUVBuffer (flutter/engine#40248)

* ec151bf2c Revert Dart SDK to c766fffb626e (flutter/engine#40315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdero bdero bdero approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees

@ColdPaleLight ColdPaleLight

Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Impeller] matrix image filter is not working as expected with nested saving layers
2 participants
@ColdPaleLight @bdero