Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use 32 cores builder for linux v2 web engine. #40336

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Use 32 cores builder for linux v2 web engine. #40336

merged 1 commit into from
Mar 16, 2023

Conversation

godofredoc
Copy link
Contributor

Web engine builds are not using goma and they need to run on machines with more the 8 cpus.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Use 32 cores builder for linux v2 web engine.
190f8c1 
Web engine builds are not using goma and they need to run on machines
with more the 8 cpus.
eyebrowsoffire
eyebrowsoffire approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2023
@auto-submit auto-submit bot merged commit eca44ae into flutter:main Mar 16, 2023
@godofredoc godofredoc deleted the use_32_web branch March 16, 2023 03:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 16, 2023
@engine-flutter-autoroll
eca44aed4 Use 32 cores builder for linux v2 web engine. (flutter/engi…
c120464 
…ne#40336)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 16, 2023
@engine-flutter-autoroll
eca44aed4 Use 32 cores builder for linux v2 web engine. (flutter/engi…
1b7885c 
…ne#40336) (#122777)

Roll Flutter Engine from ecb211da9efc to eca44aed4ee1 (1 revision)
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Mar 16, 2023
flutter: eca44aed4 Use 32 cores builder for linux v2 web engine. (flu…
7f2b7d7 
…tter/engine#40336) (#122777)

Commit: 1b7885ce1be1aaa567ebd60d3be09eb1c5da156a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2023
@engine-flutter-autoroll
1b7885c eca44aed4 Use 32 cores builder for linux v2 web engine. (flut…
a9de026 
…ter/engine#40336) (flutter/flutter#122777)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2023
@engine-flutter-autoroll
1b7885c eca44aed4 Use 32 cores builder for linux v2 web engine. (flut…
7fca614 
…ter/engine#40336) (flutter/flutter#122777)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2023
@engine-flutter-autoroll
1b7885c eca44aed4 Use 32 cores builder for linux v2 web engine. (flut…
b1e90a2 
…ter/engine#40336) (flutter/flutter#122777)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2023
@engine-flutter-autoroll
1b7885c eca44aed4 Use 32 cores builder for linux v2 web engine. (flut…
86fe135 
…ter/engine#40336) (flutter/flutter#122777)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2023
@engine-flutter-autoroll
1b7885c eca44aed4 Use 32 cores builder for linux v2 web engine. (flut…
d186e2e 
…ter/engine#40336) (flutter/flutter#122777)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
1b7885c eca44aed4 Use 32 cores builder for linux v2 web engine. (flut…
d89a92e 
…ter/engine#40336) (flutter/flutter#122777)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
1b7885c eca44aed4 Use 32 cores builder for linux v2 web engine. (flut…
83198a6 
…ter/engine#40336) (flutter/flutter#122777)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godofredoc @eyebrowsoffire