Use analyzer from dart source everywhere #40398

goderbauer · 2023-03-17T20:31:52Z

In #40328 it tripped me up that the analyzer used by tools/api_check behaved differently than the analyzer used by web_sdk. The reason for that mystery was: tools/api_check uses the analyzer directly from the dart sources, while web_sdk used an (outdated) version from pub. The version from pub will always be slightly behind, which is why web_sdk sometimes requires fiddling with experiment flags to get it to behave as expected (see #40386). That's annoying and having to deal with different analyzer versions is confusing. This change migrates web_sdk to always use the up-to-date analyzer from the dart sources directly, just like tools/api_check does:

engine/tools/api_check/pubspec.yaml

Lines 40 to 82 in fc57995

    
           dependency_overrides: 
        
             _fe_analyzer_shared: 
        
               path: ../../../third_party/dart/pkg/_fe_analyzer_shared 
        
             analyzer: 
        
               path: ../../../third_party/dart/pkg/analyzer 
        
             async: 
        
               path: ../../../third_party/dart/third_party/pkg/async 
        
             async_helper: 
        
               path: ../../../third_party/dart/pkg/async_helper 
        
             collection: 
        
               path: ../../../third_party/dart/third_party/pkg/collection 
        
             convert: 
        
               path: ../../../third_party/dart/third_party/pkg/convert 
        
             crypto: 
        
               path: ../../../third_party/dart/third_party/pkg/crypto 
        
             expect: 
        
               path: ../../../third_party/dart/pkg/expect 
        
             file: 
        
               path: ../../../third_party/pkg/file/packages/file 
        
             glob: 
        
               path: ../../../third_party/dart/third_party/pkg/glob 
        
             litetest: 
        
               path: ../../testing/litetest 
        
             meta: 
        
               path: ../../../third_party/dart/pkg/meta 
        
             package_config: 
        
               path: ../../../third_party/dart/third_party/pkg/package_config 
        
             path: 
        
               path: ../../../third_party/dart/third_party/pkg/path 
        
             pub_semver: 
        
               path: ../../../third_party/dart/third_party/pkg/pub_semver 
        
             source_span: 
        
               path: ../../../third_party/dart/third_party/pkg/source_span 
        
             string_scanner: 
        
               path: ../../../third_party/dart/third_party/pkg/string_scanner 
        
             term_glyph: 
        
               path: ../../../third_party/dart/third_party/pkg/term_glyph 
        
             typed_data: 
        
               path: ../../../third_party/dart/third_party/pkg/typed_data 
        
             watcher: 
        
               path: ../../../third_party/dart/third_party/pkg/watcher 
        
             yaml: 
        
               path: ../../../third_party/dart/third_party/pkg/yaml

goderbauer · 2023-03-17T20:33:15Z

@mdebbar Can you take another look at this? Sorry with the churn on this one, but I think this approach will lessen future pain when it comes to upgrading to new dart versions.

…122942) * e6334f166 [web] Remove image codecs from Canvaskit Chromium (flutter/engine#40309) * 56727d62c Revert "[Impeller] mark decoded images as optimized for GPU access (#40356)" (flutter/engine#40387) * 2cd19e3d1 Wrap the iOS platform message handler in an autorelease pool block (flutter/engine#40373) * bab7853ad Update analyzer for api_conform_test (flutter/engine#40386) * 87b2e82d1 Roll Fuchsia Mac SDK from z32cF6YFs6CvZbY3g... to 4ZrEK2uzGdp_Gz3DU... (flutter/engine#40385) * fc57995fe Ignore some MTLCompiler failures in impeller unit tests (flutter/engine#40391) * 2398c5222 Add doc comment to Pipeline (flutter/engine#40388) * f585d4bc5 [macOS] Remove a single accessibility root assumption (flutter/engine#40316) * 940cf3c98 remove temporary flag and make FlutterTest the default font for real (flutter/engine#40352) * a1bf9fd2a drawTextBlob should not be compatible with opacity inheritance (flutter/engine#40396) * 55bf0d85e Use bundled analyzer everywhere (flutter/engine#40398) * 8e580414a Roll Skia from 9bfb45d3e065 to 49b902e5fb91 (11 revisions) (flutter/engine#40397) * 77c53d25e Default the CanvasKit base URL to local artifacts. (flutter/engine#40293) * 625ea5395 Roll Skia from 49b902e5fb91 to aa983f5486f0 (7 revisions) (flutter/engine#40404) * 867679fac [Impeller] Add playground flag to render for a specific amount of time. (flutter/engine#40377) * d74169608 [Impeller] Remove unused bounds method from typographer interface (flutter/engine#40406) * 941323d77 Provisional iOS impeller flag flip (flutter/engine#40405) * bb971ab55 Revert "Default the CanvasKit base URL to local artifacts. (#40293)" (flutter/engine#40415)

Use bundled analyzer everywhere

660ff94

flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 17, 2023

goderbauer requested a review from mdebbar March 17, 2023 20:33

mdebbar approved these changes Mar 17, 2023

View reviewed changes

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2023

auto-submit bot merged commit 55bf0d8 into flutter:main Mar 17, 2023

engine-flutter-autoroll mentioned this pull request Mar 17, 2023

Roll Flutter Engine from 991cf41eb850 to 77c53d25eeeb (13 revisions) flutter/flutter#122933

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 17, 2023

55bf0d85e Use bundled analyzer everywhere (flutter/engine#40398)

cbc3caa

engine-flutter-autoroll mentioned this pull request Mar 18, 2023

Roll Flutter Engine from 991cf41eb850 to 625ea5395042 (14 revisions) flutter/flutter#122934

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 18, 2023

55bf0d85e Use bundled analyzer everywhere (flutter/engine#40398)

de9e89f

engine-flutter-autoroll mentioned this pull request Mar 18, 2023

Roll Flutter Engine from 991cf41eb850 to 867679facd71 (15 revisions) flutter/flutter#122935

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 18, 2023

55bf0d85e Use bundled analyzer everywhere (flutter/engine#40398)

a271a57

engine-flutter-autoroll mentioned this pull request Mar 18, 2023

Roll Flutter Engine from 991cf41eb850 to d741696082ad (16 revisions) flutter/flutter#122938

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 18, 2023

55bf0d85e Use bundled analyzer everywhere (flutter/engine#40398)

e23cd9e

engine-flutter-autoroll mentioned this pull request Mar 18, 2023

Roll Flutter Engine from 991cf41eb850 to 941323d77c31 (17 revisions) flutter/flutter#122939

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 18, 2023

55bf0d85e Use bundled analyzer everywhere (flutter/engine#40398)

c6d7a12

engine-flutter-autoroll mentioned this pull request Mar 18, 2023

Roll Flutter Engine from 991cf41eb850 to bb971ab55f41 (18 revisions) flutter/flutter#122942

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 18, 2023

55bf0d85e Use bundled analyzer everywhere (flutter/engine#40398)

2e8a45b

engine-flutter-autoroll mentioned this pull request Mar 18, 2023

Manual roll Flutter Engine from 991cf41eb850 to bb971ab55f41 (18 revisions) flutter/flutter#122955

Merged

zanderso pushed a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 18, 2023

55bf0d85e Use bundled analyzer everywhere (flutter/engine#40398)

bc37d81

goderbauer deleted the syncAnalyzer branch July 13, 2023 18:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use analyzer from dart source everywhere #40398

Use analyzer from dart source everywhere #40398

goderbauer commented Mar 17, 2023

goderbauer commented Mar 17, 2023

	dependency_overrides:
	_fe_analyzer_shared:
	path: ../../../third_party/dart/pkg/_fe_analyzer_shared
	analyzer:
	path: ../../../third_party/dart/pkg/analyzer
	async:
	path: ../../../third_party/dart/third_party/pkg/async
	async_helper:
	path: ../../../third_party/dart/pkg/async_helper
	collection:
	path: ../../../third_party/dart/third_party/pkg/collection
	convert:
	path: ../../../third_party/dart/third_party/pkg/convert
	crypto:
	path: ../../../third_party/dart/third_party/pkg/crypto
	expect:
	path: ../../../third_party/dart/pkg/expect
	file:
	path: ../../../third_party/pkg/file/packages/file
	glob:
	path: ../../../third_party/dart/third_party/pkg/glob
	litetest:
	path: ../../testing/litetest
	meta:
	path: ../../../third_party/dart/pkg/meta
	package_config:
	path: ../../../third_party/dart/third_party/pkg/package_config
	path:
	path: ../../../third_party/dart/third_party/pkg/path
	pub_semver:
	path: ../../../third_party/dart/third_party/pkg/pub_semver
	source_span:
	path: ../../../third_party/dart/third_party/pkg/source_span
	string_scanner:
	path: ../../../third_party/dart/third_party/pkg/string_scanner
	term_glyph:
	path: ../../../third_party/dart/third_party/pkg/term_glyph
	typed_data:
	path: ../../../third_party/dart/third_party/pkg/typed_data
	watcher:
	path: ../../../third_party/dart/third_party/pkg/watcher
	yaml:
	path: ../../../third_party/dart/third_party/pkg/yaml

Use analyzer from dart source everywhere #40398

Use analyzer from dart source everywhere #40398

Conversation

goderbauer commented Mar 17, 2023

goderbauer commented Mar 17, 2023