This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Migrate EventListener's to JS types. #40566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
|
@eyebrowsoffire ptal, @mdebbar @ditman please feel free to review if you like. This one is kind of a fun one, and I think this is the best pattern for functions moving forward. It gives us the best of both worlds, type safety and sane JS semantics. |
|
Oh please diff against commit 1, I still need to land the canvaskit changes. |
|
@eyebrowsoffire okay, ptal. this is ready to go. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 4, 2023
…124136) flutter/engine@e860fa8...8edd3c0 2023-04-04 joshualitt@google.com [web] Migrate EventListener's to JS types. (flutter/engine#40566) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Not sure why exactly, but it looks like a CK benchmark improved with this change: |
|
@jonahwilliams I know this is confusing, but the chart you linked to is Here's the real average for the benchmark, and it remained stable before and after this PR: |
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…lutter#124136) flutter/engine@e860fa8...8edd3c0 2023-04-04 joshualitt@google.com [web] Migrate EventListener's to JS types. (flutter/engine#40566) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.