Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@ditman
Copy link
Member

@ditman ditman commented Mar 27, 2023

This PR relands #40615, by:

   info - test/engine/assets_test.dart:5:1 - This annotation must
     be attached to a library directive. Try attaching library
     annotations to library directives. - library_annotations

Fixes: flutter/flutter#122987

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

ditman added 2 commits March 27, 2023 13:08
This solves an issue with the `library_annotations` lint that was
added to the repo:

```
   info - test/engine/assets_test.dart:5:1 - This annotation must
     be attached to a library directive. Try attaching library
     annotations to library directives. - library_annotations
```
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 27, 2023
@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2023
@auto-submit auto-submit bot merged commit 0d8d295 into flutter:main Mar 28, 2023
@ditman ditman deleted the reland-assetbase branch March 28, 2023 20:22
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move the undocumented assetBase meta tag API to flutter.js

2 participants