This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add a CommandBuffer::WaitUntilScheduled API #41303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Nit about the API name but otherwise LGTM.
impeller/renderer/command_buffer.h
Outdated
| //---------------------------------------------------------------------------- | ||
| /// @brief Force execution of pending GPU commands. | ||
| /// | ||
| void Flush(); |
Member
There was a problem hiding this comment.
We should use the more descriptive names for these in the modern backends. WaitUntilScheduled and WaitUntilSubmitted. This one is a wait for scheduled.
This can be used by IO thread operations such as image decoding to ensure that the results of GPU commands become visible to the raster thread.
jason-simmons
force-pushed
the
iplr_wait_for_completion
branch
from
ebcd3a9 to
01f6694
Compare
Member
|
@jason-simmons Can we land this? |
jason-simmons
changed the title
chinmaygarde
approved these changes
Apr 21, 2023
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 22, 2023
…125346) flutter/engine@462e9bb...d96a095 2023-04-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Edv0I0o8GQ7c0z8XK... to RdOaZ2-aDsn_64hk5... (flutter/engine#41407) 2023-04-21 skia-flutter-autoroll@skia.org Roll Dart SDK from fabaeef00dfb to b6de2d42e58d (2 revisions) (flutter/engine#41401) 2023-04-21 jason-simmons@users.noreply.github.com [Impeller] Add a CommandBuffer::WaitUntilScheduled API (flutter/engine#41303) 2023-04-21 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned off the TextRotated golden test again (flutter/engine#41399) 2023-04-21 skia-flutter-autoroll@skia.org Roll Skia from 5754b81988b8 to aa592c60846d (11 revisions) (flutter/engine#41398) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Edv0I0o8GQ7c to RdOaZ2-aDsn_ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used by IO thread operations such as image decoding to ensure that the results of GPU commands become visible to the raster thread.