This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Change view ID's type to signed and a typedef #41653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do you plan to cherrypick this for the upcoming release? Otherwise this is a breaking change. |
Contributor
Author
Whether it's a breaking change also depends on whether we actually break anyone. In this case, I don't think anyone is using |
cbracken
approved these changes
May 3, 2023
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Nice! Thanks for the cleanup!
dkwingsmt
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 5, 2023
…126135) flutter/engine@a885ed4...e7cd291 2023-05-05 dkwingsmt@users.noreply.github.com [macOS] Change view ID's type to signed and a typedef (flutter/engine#41653) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the view ID type to
int64_tand typedef it toFlutterViewIdPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.