[web] Move web-only initialization APIs to dart:ui_web
#43111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
reviewed
Jun 22, 2023
| /// Flutter framework. | ||
| /// | ||
| /// Unlike [warmupEngine], this method initializes UI and non-UI services. | ||
| Future<void> initializePlatform() async { |
There was a problem hiding this comment.
Why not call it initializeEngine?
There was a problem hiding this comment.
No reason. I just removed the webOnly prefix from the name. I think initializeEngine makes more sense, and is more consistent with warmupEngine.
ditman
reviewed
Jun 22, 2023
| } | ||
| // TODO(mdebbar): Deprecate this and remove it. | ||
| // https://github.com/flutter/flutter/issues/127395 | ||
| bool get debugEmulateFlutterTesterEnvironment { |
There was a problem hiding this comment.
Is this something that is needed for end users, or is this only for our testing? If it's only for our engine testing, it probably should live within engine or similar, rather than be exposed to web_ui?
There was a problem hiding this comment.
(Never mind, this is used all over the bootstrap and the framework!)
There was a problem hiding this comment.
Alternatively, this could be hidden behind JS-interop, if we don't want it to show up in the public APIs.
There was a problem hiding this comment.
debugEmulateFlutterTesterEnvironment has effect on several things including the usage of Ahem font. If users want their tests to produce real text (e.g. for screenshots), they have to disable debugEmulateFlutterTesterEnvironment.
|
yjbanov
approved these changes
Jun 27, 2023
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 29, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 29, 2023
…129799) flutter/engine@cd9ce66...68cc1a7 2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from a4d0373cd414 to c83f8ba23a80 (3 revisions) (flutter/engine#43340) 2023-06-29 mdebbar@google.com [web] Move web-only initialization APIs to `dart:ui_web` (flutter/engine#43111) 2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from 8ada2c4b2947 to a4d0373cd414 (14 revisions) (flutter/engine#43338) 2023-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 656201921b30 to ecc2440be198 (1 revision) (flutter/engine#43333) 2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from 0c320b3d5b64 to 8ada2c4b2947 (1 revision) (flutter/engine#43332) 2023-06-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fxCNy4QivAngZXkvM... to nboAFpQUzwtrESDVo... (flutter/engine#43334) 2023-06-29 kustermann@google.com Prepare for utf8.encode() to return more precise Uint8List type (flutter/engine#43335) 2023-06-29 jason-simmons@users.noreply.github.com [Impeller] Ensure that the auto-release pool is available when the GoldenPlaygroundTestImpl is destructed (flutter/engine#43322) 2023-06-29 uysalere@gmail.com [fuchsia] Remove strict equality check for SkMatrix comparison for Flâ�¦ (flutter/engine#43309) 2023-06-29 jason-simmons@users.noreply.github.com [Impeller] Add an autorelease pool to the GoldenTests fixture (flutter/engine#43323) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from fxCNy4QivAng to nboAFpQUzwtr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
| Old API in `dart:ui` | New API in `dart:ui_web` | |-|-| | ~`webOnlyInitializePlatform`~ | ~`ui_web.initializePlatform`~ | | `webOnlyWarmupEngine` | `ui_web.bootstrapEngine` | | `debugEmulateFlutterTesterEnvironment` | `ui_web.debugEmulateFlutterTesterEnvironment` | | `webOnlySetPluginHandler` | `ui_web.setPluginHandler` | Part of flutter/flutter#126831
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart:uidart:ui_webwebOnlyInitializePlatformui_web.initializePlatformwebOnlyWarmupEngineui_web.bootstrapEnginedebugEmulateFlutterTesterEnvironmentui_web.debugEmulateFlutterTesterEnvironmentwebOnlySetPluginHandlerui_web.setPluginHandlerPart of flutter/flutter#126831