This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Avoid channel clone #43181
Merged
Avoid channel clone #43181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
tamird
force-pushed
the
remove-clone-channel
branch
3 times, most recently
from
38baf08 to
cd4cb2c
Compare
Use fdio_fd_transfer instead of fdio_fd_clone.
Use fdio_open_fd_at instead of openat to deal in zx_status_t rather than errno.
tamird
force-pushed
the
remove-clone-channel
branch
from
cd4cb2c to
9b35576
Compare
tarobins
approved these changes
Jun 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 26, 2023
…129582) flutter/engine@f2d70cc...0da06de 2023-06-26 tamird@google.com Avoid channel clone (flutter/engine#43181) 2023-06-26 5236035+fzyzcjy@users.noreply.github.com ParagraphStyle uses the wrong bit mask (flutter/engine#43070) 2023-06-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3Y8TbEFhQUKOJBLQ4... to bj_X2Se1zObk_l_CC... (flutter/engine#43205) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 3Y8TbEFhQUKO to bj_X2Se1zObk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
Use fdio_fd_transfer instead of fdio_fd_clone.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use fdio_fd_transfer instead of fdio_fd_clone.