[Impeller] Add support to embedder for Impeller on GL (via Angle on Windows). #43388

jonahwilliams · 2023-07-03T22:15:31Z

Actually works now, though there is some issue with the default fbo stencil so I've filled flutter/flutter#130048

Other issues:

~~Rendering looks wrong~~
~~Resizing window hangs~~
~~Reactor isn't set up correctly and all blit passes are currently failing.~~
~~Needs to handle falling back to sample count of 1 like we do on Android~~.

shell/platform/windows/angle_surface_manager.cc

impeller/renderer/backend/gles/render_pass_gles.cc

jonahwilliams · 2023-07-06T18:45:54Z

shell/platform/embedder/embedder_surface_gl_impeller.cc

+// |EmbedderSurface|
+sk_sp<GrDirectContext> EmbedderSurfaceGLImpeller::CreateResourceContext()
+    const {
+  sk_sp<GrDirectContext> resource_context;


This seems wrong but I'm not sure how else to make it work. 🤷‍♂️

I don't think you need this.

You should just see if you can make the resource context current, and if you can mark the worker as allowed to react on this thread. And then always return nullptr.

Returning a valid context from here should not be required and we should not be creating a GrContext when using Impeller.

Ahh OK, that works and makes much more sense. I briefly read through the code and thought this still needed to be constructed

The resource context is a performance improving optional thing. Impeller handles things differently by just using worker threads and the reactor mechanism - Skia OTOH expects you to manage a context for the IO thread.

Returning nullptr here should be tolerated anywhere. We may eventually want some better way to signal what this method is actually doing but right now it's a little hard to think about the best way to clean up all the duplicated branches where we've baked Skia concepts into things (like methods that return nullptr for GrContexts in various spots, or nullptr for impeller::Contexts in others).

jonahwilliams · 2023-07-09T23:41:31Z

shell/gpu/gpu_surface_gl_impeller.cc

@@ -80,10 +80,14 @@ std::unique_ptr<SurfaceFrame> GPUSurfaceGLImpeller::AcquireFrame(
    return nullptr;
  }

+  GLFrameInfo frame_info = {static_cast<uint32_t>(size.width()),
+                            static_cast<uint32_t>(size.height())};
+  const GLFBOInfo fbo_info = delegate_->GLContextFBO(frame_info);


Adding this is enough to get window resizing working.

jonahwilliams · 2023-07-12T18:42:10Z

Ahh the problem was the #ifdef instead of #if

auto-submit · 2023-07-12T18:43:42Z

auto label is removed for flutter/engine, pr: 43388, due to - The status or check suite Linux Fuchsia FEMU has failed. Please fix the issues identified (or deflake) before re-applying this label.

jonahwilliams · 2023-07-12T18:47:07Z

ahh I guess not, linux fuchsia seems to be trying to enable impeller :(

jonahwilliams · 2023-07-12T23:08:12Z

@dnfield I put the nognchecks back. I'm not sure exactly how to untangle this, but it seems like its mostly a problem with however we're configuring fuchsia builds. Impeller ends up in a partially enabled state and that is confusing the build rules.

…Angle on Windows). (flutter/engine#43388)

…130496) Roll Flutter Engine from 16e2ab7e986c to b4080361f2f9 (28 revisions) flutter/engine@16e2ab7...b408036 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from e5ec341bc3ca to 56b68ce6196c (1 revision) (flutter/engine#43633) 2023-07-13 skia-flutter-autoroll@skia.org Roll Dart SDK from f499e91e8cb2 to ade4dae923f3 (1 revision) (flutter/engine#43632) 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 811b046c673b to e5ec341bc3ca (1 revision) (flutter/engine#43631) 2023-07-13 ian@hixie.ch Make GOMA state automatic by default (flutter/engine#43584) 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from c8da0c657c4e to 811b046c673b (3 revisions) (flutter/engine#43630) 2023-07-13 chinmaygarde@google.com [Impeller] Remove unactionable error logs and use structure chains for instance creation. (flutter/engine#43629) 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 7f391ea9164e to c8da0c657c4e (1 revision) (flutter/engine#43628) 2023-07-13 chinmaygarde@google.com [Impeller] Add RAII wrappers for VMA objects. (flutter/engine#43626) 2023-07-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1STsUj0X5YgpiSNEb... to xBJq6PsO5ebblODMe... (flutter/engine#43627) 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 6ed93436d57c to 7f391ea9164e (1 revision) (flutter/engine#43625) 2023-07-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 8f8f281ccdc6 to f499e91e8cb2 (3 revisions) (flutter/engine#43623) 2023-07-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 0fvk838jTDNQ_l43k... to 3C7P0w8ySmtqpyi3S... (flutter/engine#43622) 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from bedc92598644 to 6ed93436d57c (3 revisions) (flutter/engine#43621) 2023-07-13 jonahwilliams@google.com [Impeller] Add support to embedder for Impeller on GL (via Angle on Windows). (flutter/engine#43388) 2023-07-12 jonahwilliams@google.com [Impeller] Allocate buffers out of a pool on the raster thread. (flutter/engine#43564) 2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from 4e989b1564ee to bedc92598644 (1 revision) (flutter/engine#43617) 2023-07-12 flar@google.com move rtree and canvas_spy sources to Fuchsia sub-directory (flutter/engine#43615) 2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from 68e3c0b3eea7 to 4e989b1564ee (6 revisions) (flutter/engine#43614) 2023-07-12 ian@hixie.ch Document (and assert) that channel names can't contains nulls (flutter/engine#43593) 2023-07-12 58529443+srujzs@users.noreply.github.com Reland "Refactor JSNumber.toDart and Object.toJS" (flutter/engine#43363) 2023-07-12 31859944+LongCatIsLooong@users.noreply.github.com Add a flag to `ParagraphBuilder` for rounding hack migration (flutter/engine#43118) 2023-07-12 john@johnmccutchan.com [Impeller] Fixes for asymmetric stencil descriptors (flutter/engine#43535) 2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from adeeb8d50f7c to 68e3c0b3eea7 (1 revision) (flutter/engine#43609) 2023-07-12 flar@google.com Add comment to use of 3x3 mapRect in TransformLayer (flutter/engine#43608) 2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from a251a36ea519 to adeeb8d50f7c (1 revision) (flutter/engine#43606) 2023-07-12 skia-flutter-autoroll@skia.org Roll Dart SDK from b95f6531c726 to 8f8f281ccdc6 (2 revisions) (flutter/engine#43607) 2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from ebc149cff431 to a251a36ea519 (2 revisions) (flutter/engine#43604) 2023-07-12 jonahwilliams@google.com [Impeller] Use new SkParagraph APIs for stroked text. (flutter/engine#41735) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 1STsUj0X5Ygp to xBJq6PsO5ebb fuchsia/sdk/core/mac-amd64 from 0fvk838jTDNQ to 3C7P0w8ySmtq If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

) All current desktop backends will support Impeller after flutter/engine#43388 lands.

…lutter#130496) Roll Flutter Engine from 16e2ab7e986c to b4080361f2f9 (28 revisions) flutter/engine@16e2ab7...b408036 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from e5ec341bc3ca to 56b68ce6196c (1 revision) (flutter/engine#43633) 2023-07-13 skia-flutter-autoroll@skia.org Roll Dart SDK from f499e91e8cb2 to ade4dae923f3 (1 revision) (flutter/engine#43632) 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 811b046c673b to e5ec341bc3ca (1 revision) (flutter/engine#43631) 2023-07-13 ian@hixie.ch Make GOMA state automatic by default (flutter/engine#43584) 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from c8da0c657c4e to 811b046c673b (3 revisions) (flutter/engine#43630) 2023-07-13 chinmaygarde@google.com [Impeller] Remove unactionable error logs and use structure chains for instance creation. (flutter/engine#43629) 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 7f391ea9164e to c8da0c657c4e (1 revision) (flutter/engine#43628) 2023-07-13 chinmaygarde@google.com [Impeller] Add RAII wrappers for VMA objects. (flutter/engine#43626) 2023-07-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1STsUj0X5YgpiSNEb... to xBJq6PsO5ebblODMe... (flutter/engine#43627) 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 6ed93436d57c to 7f391ea9164e (1 revision) (flutter/engine#43625) 2023-07-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 8f8f281ccdc6 to f499e91e8cb2 (3 revisions) (flutter/engine#43623) 2023-07-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 0fvk838jTDNQ_l43k... to 3C7P0w8ySmtqpyi3S... (flutter/engine#43622) 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from bedc92598644 to 6ed93436d57c (3 revisions) (flutter/engine#43621) 2023-07-13 jonahwilliams@google.com [Impeller] Add support to embedder for Impeller on GL (via Angle on Windows). (flutter/engine#43388) 2023-07-12 jonahwilliams@google.com [Impeller] Allocate buffers out of a pool on the raster thread. (flutter/engine#43564) 2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from 4e989b1564ee to bedc92598644 (1 revision) (flutter/engine#43617) 2023-07-12 flar@google.com move rtree and canvas_spy sources to Fuchsia sub-directory (flutter/engine#43615) 2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from 68e3c0b3eea7 to 4e989b1564ee (6 revisions) (flutter/engine#43614) 2023-07-12 ian@hixie.ch Document (and assert) that channel names can't contains nulls (flutter/engine#43593) 2023-07-12 58529443+srujzs@users.noreply.github.com Reland "Refactor JSNumber.toDart and Object.toJS" (flutter/engine#43363) 2023-07-12 31859944+LongCatIsLooong@users.noreply.github.com Add a flag to `ParagraphBuilder` for rounding hack migration (flutter/engine#43118) 2023-07-12 john@johnmccutchan.com [Impeller] Fixes for asymmetric stencil descriptors (flutter/engine#43535) 2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from adeeb8d50f7c to 68e3c0b3eea7 (1 revision) (flutter/engine#43609) 2023-07-12 flar@google.com Add comment to use of 3x3 mapRect in TransformLayer (flutter/engine#43608) 2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from a251a36ea519 to adeeb8d50f7c (1 revision) (flutter/engine#43606) 2023-07-12 skia-flutter-autoroll@skia.org Roll Dart SDK from b95f6531c726 to 8f8f281ccdc6 (2 revisions) (flutter/engine#43607) 2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from ebc149cff431 to a251a36ea519 (2 revisions) (flutter/engine#43604) 2023-07-12 jonahwilliams@google.com [Impeller] Use new SkParagraph APIs for stroked text. (flutter/engine#41735) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 1STsUj0X5Ygp to xBJq6PsO5ebb fuchsia/sdk/core/mac-amd64 from 0fvk838jTDNQ to 3C7P0w8ySmtq If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

…ter#130430) All current desktop backends will support Impeller after flutter/engine#43388 lands.

…indows). (flutter#43388) Actually works now, though there is some issue with the default fbo stencil so I've filled flutter/flutter#130048 Other issues: * ~~Rendering looks wrong~~ * ~~Resizing window hangs~~ * ~~Reactor isn't set up correctly and all blit passes are currently failing.~~ * ~~Needs to handle falling back to sample count of 1 like we do on Android~~.

[Impeller] support Impeller via GL/Angle on Windows.

a21ab76

github-actions bot added the platform-windows label Jul 3, 2023

jonahwilliams commented Jul 3, 2023

View reviewed changes

shell/platform/windows/angle_surface_manager.cc Outdated Show resolved Hide resolved

chinmaygarde assigned jonahwilliams Jul 3, 2023

chinmaygarde added the e: impeller label Jul 3, 2023

++

24fca1c

github-actions bot removed the e: impeller label Jul 3, 2023

chinmaygarde changed the title ~~[Impeller] support Impeller via GL/Angle on Windows.~~ [Impeller] Support Impeller via GL/Angle on Windows. Jul 3, 2023

chinmaygarde added the e: impeller label Jul 3, 2023

+

b3d8c6c

github-actions bot removed the e: impeller label Jul 3, 2023

++

f6cc626

github-actions bot added the e: impeller label Jul 5, 2023

jonahwilliams commented Jul 5, 2023

View reviewed changes

impeller/renderer/backend/gles/render_pass_gles.cc Outdated Show resolved Hide resolved

jonahwilliams mentioned this pull request Jul 6, 2023

[Impeller] Discarding stencil attachment on default FBO causes Angle to invalidate color texture. flutter/flutter#130048

Open

jonahwilliams added 2 commits July 5, 2023 17:45

++

e7c5f34

fix order.

a52ea8e

jonahwilliams mentioned this pull request Jul 6, 2023

[Impeller] Unclear how to set up resource context for Impeller on OpenGL / embedder flutter/flutter#130083

Closed

++

cbe8472

jonahwilliams commented Jul 6, 2023

View reviewed changes

jonahwilliams added 4 commits July 6, 2023 11:49

formatting

fbd4bae

Merge branch 'main' of github.com:flutter/engine into windows

2e9efed

Merge branch 'main' of github.com:flutter/engine into windows

58f9309

fix window resize

26bc607

jonahwilliams commented Jul 9, 2023

View reviewed changes

jonahwilliams added 2 commits July 9, 2023 17:08

configure windows engine based on impeller usage.

f260393

++

e35a5bf

jonahwilliams marked this pull request as ready for review July 10, 2023 00:53

jonahwilliams requested review from chinmaygarde and loic-sharma July 10, 2023 15:12

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2023

jonahwilliams mentioned this pull request Jul 12, 2023

[flutter_tools] remove desktop device restrictions on Impeller. flutter/flutter#130430

Merged

++

f4a52fb

chinmaygarde approved these changes Jul 12, 2023

View reviewed changes

jonahwilliams added 4 commits July 12, 2023 12:55

++

17025c6

++

264b474

++

6ae81d6

++

9dc60c2

jonahwilliams changed the title ~~[Impeller] Support Impeller via GL/Angle on Windows.~~ [Impeller] Add support to embedder for Impeller on GL (via Angle on Windows). Jul 12, 2023

++

705cf7a

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023

auto-submit bot merged commit e478f1b into flutter:main Jul 13, 2023

engine-flutter-autoroll mentioned this pull request Jul 13, 2023

Roll Flutter Engine from 1b1ccdd1f527 to e60d4af8309e (4 revisions) flutter/flutter#130471

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2023

e478f1be2 [Impeller] Add support to embedder for Impeller on GL (via …

eecf0be

…Angle on Windows). (flutter/engine#43388)

engine-flutter-autoroll mentioned this pull request Jul 13, 2023

Roll Flutter Engine from 1b1ccdd1f527 to 76738686deaa (6 revisions) flutter/flutter#130473

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2023

e478f1be2 [Impeller] Add support to embedder for Impeller on GL (via …

8fd5084

…Angle on Windows). (flutter/engine#43388)

engine-flutter-autoroll mentioned this pull request Jul 13, 2023

Roll Flutter Engine from 16e2ab7e986c to b4080361f2f9 (28 revisions) flutter/flutter#130496

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2023

e478f1be2 [Impeller] Add support to embedder for Impeller on GL (via …

6572c6a

…Angle on Windows). (flutter/engine#43388)

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 13, 2023

[flutter_tools] remove desktop device restrictions on Impeller. (#130430

60c1f37

) All current desktop backends will support Impeller after flutter/engine#43388 lands.

LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 13, 2023

[flutter_tools] remove desktop device restrictions on Impeller. (flut…

3b9058e

…ter#130430) All current desktop backends will support Impeller after flutter/engine#43388 lands.

HidenoriMatsubayashi mentioned this pull request Aug 2, 2023

Add Impeller support sony/flutter-embedded-linux#352

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Impeller] Add support to embedder for Impeller on GL (via Angle on Windows). #43388

[Impeller] Add support to embedder for Impeller on GL (via Angle on Windows). #43388

jonahwilliams commented Jul 3, 2023 •

edited

Loading

jonahwilliams Jul 6, 2023

dnfield Jul 12, 2023

jonahwilliams Jul 12, 2023

dnfield Jul 12, 2023

jonahwilliams Jul 9, 2023

jonahwilliams commented Jul 12, 2023

auto-submit bot commented Jul 12, 2023

jonahwilliams commented Jul 12, 2023

jonahwilliams commented Jul 12, 2023

[Impeller] Add support to embedder for Impeller on GL (via Angle on Windows). #43388

[Impeller] Add support to embedder for Impeller on GL (via Angle on Windows). #43388

Conversation

jonahwilliams commented Jul 3, 2023 • edited Loading

jonahwilliams Jul 6, 2023

Choose a reason for hiding this comment

dnfield Jul 12, 2023

Choose a reason for hiding this comment

jonahwilliams Jul 12, 2023

Choose a reason for hiding this comment

dnfield Jul 12, 2023

Choose a reason for hiding this comment

jonahwilliams Jul 9, 2023

Choose a reason for hiding this comment

jonahwilliams commented Jul 12, 2023

auto-submit bot commented Jul 12, 2023

jonahwilliams commented Jul 12, 2023

jonahwilliams commented Jul 12, 2023

jonahwilliams commented Jul 3, 2023 •

edited

Loading