Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] Duplicate include removal from lazy_glyph_atlas.cc. #43453

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 6, 2023

No description provided.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde chinmaygarde changed the title Duplicate include removal from lazy_glyph_atlas.cc [Impeller] Duplicate include removal from lazy_glyph_atlas.cc. Jul 6, 2023
@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2023
@Hixie
Copy link
Contributor

Hixie commented Jul 6, 2023

test-exempt: code deletion
bonus points for making the bot consistent across repos about this rule

@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 6, 2023

auto label is removed for flutter/engine, pr: 43453, due to - The status or check suite Mac mac_clang_tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2023
@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2023
@auto-submit auto-submit bot merged commit 8aa2e65 into main Jul 7, 2023
@auto-submit auto-submit bot deleted the dnfield-patch-1 branch July 7, 2023 03:57
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2023
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Jul 7, 2023
…130116)

flutter/engine@650ff09...8aa2e65

2023-07-07 dnfield@google.com [Impeller] Duplicate include removal from lazy_glyph_atlas.cc. (flutter/engine#43453)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@dnfield
Copy link
Contributor Author

dnfield commented Jul 10, 2023

This missed 3.13 but will not require a cherry pick as it was a very minor internal cleanup for code health that has no impact on end users.

kjlubick pushed a commit to kjlubick/engine that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller needs tests
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants