Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Improve logging in the clang-tidy script #44228

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Improve logging in the clang-tidy script #44228

merged 1 commit into from
Aug 2, 2023

Conversation

jason-simmons
Copy link
Member

  • Add timestamps to process pool status logs
  • Log the remaining job names when only a few jobs are pending

See flutter/flutter#131689

@jason-simmons jason-simmons requested a review from zanderso August 1, 2023 19:36
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

matanlurey
matanlurey reviewed Aug 1, 2023
View reviewed changes
tools/clang_tidy/lib/clang_tidy.dart Outdated
@@ -89,8 +89,12 @@ class ClangTidy {
final StringSink _outSink;
final StringSink _errSink;

DateTime? _startTime;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could probably be late DateTime _startTime since that's how it's used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jason-simmons
Improve logging in the clang-tidy script
34d3196 
* Add timestamps to process pool status logs
* Log the remaining job names when only a few jobs are pending

See flutter/flutter#131689
@zanderso zanderso merged commit f0ce6b6 into flutter:main Aug 2, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2023
@engine-flutter-autoroll
f0ce6b670 Improve logging in the clang-tidy script (flutter/engine#44228
07dd537 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2023
@engine-flutter-autoroll
f0ce6b670 Improve logging in the clang-tidy script (flutter/engine#44228
9ee9cf1 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2023
@engine-flutter-autoroll
f0ce6b670 Improve logging in the clang-tidy script (flutter/engine#44228
80d70a7 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2023
@engine-flutter-autoroll
f0ce6b670 Improve logging in the clang-tidy script (flutter/engine#44228
956e4d9 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2023
@engine-flutter-autoroll
f0ce6b670 Improve logging in the clang-tidy script (flutter/engine#44228
ef3b2be 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2023
@engine-flutter-autoroll
f0ce6b670 Improve logging in the clang-tidy script (flutter/engine#44228
10a8603 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2023
@engine-flutter-autoroll
f0ce6b670 Improve logging in the clang-tidy script (flutter/engine#44228
fcb4001 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2023
@engine-flutter-autoroll
f0ce6b670 Improve logging in the clang-tidy script (flutter/engine#44228
426434e 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2023
@engine-flutter-autoroll
f0ce6b670 Improve logging in the clang-tidy script (flutter/engine#44228
dbb7c86 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2023
@engine-flutter-autoroll
f0ce6b670 Improve logging in the clang-tidy script (flutter/engine#44228
f98661b 
)
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Aug 3, 2023
@engine-flutter-autoroll
Manual roll Flutter Engine from 9304c0074d29 to 4c1157b9da54 (24 revi…
c00d241 
…sions) (#131830)

Manual roll requested by jacksongardner@google.com

flutter/engine@9304c00...4c1157b

2023-08-03 jacksongardner@google.com Revert Android Hardware Texture PRs (flutter/engine#44310)
2023-08-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 87df1bbcea5e to 3b9af2825d47 (2 revisions) (flutter/engine#44308)
2023-08-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Hx7ap5qcoqRIknnnG... to WwFjJuQF_rpToCYPJ... (flutter/engine#44306)
2023-08-03 jason-simmons@users.noreply.github.com Check whether the lookup of android.hardware.HardwareBuffer found a class (flutter/engine#44304)
2023-08-02 bdero@google.com [Impeller] Add placeholder filter input. (flutter/engine#44290)
2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from 6c1bab070220 to 6a09e41ce6ea (1 revision) (flutter/engine#44300)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from fd5bd67d532f to c0956a252f30 (1 revision) (flutter/engine#44296)
2023-08-02 chris@bracken.jp [iOS] Fix use-after-free in setBinaryMessenger (flutter/engine#44294)
2023-08-02 louiseh0313@gmail.com Add Search Web to selection controls on iOS (flutter/engine#43324)
2023-08-02 jason-simmons@users.noreply.github.com Improve logging in the clang-tidy script (flutter/engine#44228)
2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from 335c6b86d70b to 6c1bab070220 (1 revision) (flutter/engine#44291)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 25f5a32367ad to fd5bd67d532f (2 revisions) (flutter/engine#44289)
2023-08-02 john@johnmccutchan.com Be sure to clear exceptions after a failed JNI lookup (flutter/engine#44293)
2023-08-02 derekx@google.com Handle deprecation of Dart_TimelineEvent Embedder API (flutter/engine#42497)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from ccc17f784e5d to 25f5a32367ad (4 revisions) (flutter/engine#44283)
2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from 01ee134bb223 to 335c6b86d70b (2 revisions) (flutter/engine#44287)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 7104d0e8863f to ccc17f784e5d (2 revisions) (flutter/engine#44279)
2023-08-02 41930132+hellohuanlin@users.noreply.github.com [ios][autocorrection]disable auto-correction highlight in iOS 17 (flutter/engine#44176)
2023-08-02 john@johnmccutchan.com Reland Introduce TextureRegistry.ImageTexture and HardwareBufferExternalTextureGL (flutter/engine#44278)
2023-08-02 skia-flutter-autoroll@skia.org Roll Dart SDK from afbaf4216fc8 to 87df1bbcea5e (1 revision) (flutter/engine#44276)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 93764a98b866 to 7104d0e8863f (4 revisions) (flutter/engine#44273)
2023-08-02 jason-simmons@users.noreply.github.com [Impeller] Fix leak of wrapped TextureMTL objects in the Metal embedder API (flutter/engine#44245)
2023-08-02 737941+loic-sharma@users.noreply.github.com Revert "Listen to window notifications to update application lifecycle" (flutter/engine#44275)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 514c66ce0471 to 93764a98b866 (1 revision) (flutter/engine#44270)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from Hx7ap5qcoqRI to WwFjJuQF_rpT

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@chinmaygarde chinmaygarde mentioned this pull request Aug 7, 2023
Closed
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
@jason-simmons @gaaclarke
Improve logging in the clang-tidy script (flutter#44228)
84d8270 
* Add timestamps to process pool status logs
* Log the remaining job names when only a few jobs are pending

See flutter/flutter#131689
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matanlurey matanlurey matanlurey left review comments

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jason-simmons @matanlurey @zanderso