This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP][ios][autocorrection]disable autocorrection for ios 17 #44354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
approved these changes
Aug 4, 2023
CaseyHillers
added
the
autosubmit
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
Fix native auto-correction highlight region on top left corner. This PR uses the system auto-correction highlight on iOS 17, which was disabled by #44354 <img width="479" alt="Screenshot 2023-08-16 at 1 19 39 PM" src="https://github.com/flutter/engine/assets/41930132/a5a1dda7-ba21-462e-a65c-1afeecf7559f"> *List which issues are fixed by this PR. You must list at least one issue.* Fixes flutter/flutter#131622 Fixes flutter/flutter#131695 Fixes flutter/flutter#130818 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…#44779) Fix native auto-correction highlight region on top left corner. This PR uses the system auto-correction highlight on iOS 17, which was disabled by flutter#44354 <img width="479" alt="Screenshot 2023-08-16 at 1 19 39 PM" src="https://github.com/flutter/engine/assets/41930132/a5a1dda7-ba21-462e-a65c-1afeecf7559f"> *List which issues are fixed by this PR. You must list at least one issue.* Fixes flutter/flutter#131622 Fixes flutter/flutter#131695 Fixes flutter/flutter#130818 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #44176
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#131890
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.