This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Ignore unguarded-availability for unit test #44852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
force-pushed
the
ios_min_deploy_target
branch
from
af7f27e to
4c9d9db
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cyanglaz
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
added 2 commits
August 23, 2023 13:00
cyanglaz
force-pushed
the
ios_min_deploy_target
branch
from
4c9d9db to
e63cab3
Compare
cyanglaz
changed the title
Contributor
Author
|
After offline discussion with @stuartmorgan, we think it is better to ignore the warning for now instead of updating the flag. |
stuartmorgan-g
suggested changes
Aug 24, 2023
chinmaygarde
changed the title
stuartmorgan-g
approved these changes
Aug 25, 2023
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with nit. Thanks!
shell/platform/darwin/ios/BUILD.gn
Outdated
| "-mios-simulator-version-min=$ios_testing_deployment_target", | ||
| ] | ||
|
|
||
| # An XCode15-beta has a bug where iOS 17 API usage is not guarded. |
shell/platform/darwin/ios/BUILD.gn
Outdated
| "-mios-simulator-version-min=$ios_testing_deployment_target", | ||
| ] | ||
|
|
||
| # An XCode15-beta has a bug where iOS 17 API usage is not guarded. |
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 25, 2023
…133342) flutter/engine@3dcd217...1471967 2023-08-25 reidbaker@google.com Update gradle to 7.5.1 (flutter/engine#45113) 2023-08-25 ychris@google.com Ignore unguarded-availability for unit test (flutter/engine#44852) 2023-08-25 jonahwilliams@google.com [Impeller] avoid hashing and std::vector growth when binding descriptor sets. (flutter/engine#45070) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Ignore ungarded-availability for unit test fixes flutter/flutter#128958 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore ungarded-availability for unit test
fixes flutter/flutter#128958
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.