Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FontWeight an enum, Remove unused text classes #44960

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Make FontWeight an enum, Remove unused text classes #44960

merged 2 commits into from
Aug 22, 2023

Conversation

LongCatIsLooong
Copy link
Contributor

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review August 22, 2023 17:09
@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2023
@auto-submit auto-submit bot merged commit 2c4ada8 into flutter:main Aug 22, 2023
@LongCatIsLooong LongCatIsLooong deleted the text-cleanup branch August 22, 2023 20:35
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 22, 2023
@engine-flutter-autoroll
2c4ada880 Make FontWeight an enum, Remove unused text classes (flut…
116209f 
…ter/engine#44960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 22, 2023
@engine-flutter-autoroll
2c4ada880 Make FontWeight an enum, Remove unused text classes (flut…
3f9bd82 
…ter/engine#44960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 22, 2023
@engine-flutter-autoroll
2c4ada880 Make FontWeight an enum, Remove unused text classes (flut…
86bad2a 
…ter/engine#44960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 22, 2023
@engine-flutter-autoroll
2c4ada880 Make FontWeight an enum, Remove unused text classes (flut…
3b89164 
…ter/engine#44960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 22, 2023
@engine-flutter-autoroll
2c4ada880 Make FontWeight an enum, Remove unused text classes (flut…
c53b16c 
…ter/engine#44960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
@engine-flutter-autoroll
2c4ada880 Make FontWeight an enum, Remove unused text classes (flut…
014afcd 
…ter/engine#44960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
@engine-flutter-autoroll
2c4ada880 Make FontWeight an enum, Remove unused text classes (flut…
4849028 
…ter/engine#44960)
zanderso added a commit that referenced this pull request Aug 23, 2023
@zanderso
Revert "Make FontWeight an enum, Remove unused text classes (#44960)"
e6673c6 
This reverts commit 2c4ada8.
@zanderso zanderso mentioned this pull request Aug 23, 2023
Merged
zanderso added a commit that referenced this pull request Aug 23, 2023
@zanderso
Revert "Make FontWeight an enum, Remove unused text classes" (#44987)
139df5c 
Reverts #44960

Failing on customer_testing:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20customer_testing/59576/overview
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
@engine-flutter-autoroll
2c4ada880 Make FontWeight an enum, Remove unused text classes (flut…
7df27d3 
…ter/engine#44960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
@engine-flutter-autoroll
2c4ada880 Make FontWeight an enum, Remove unused text classes (flut…
30c6bb4 
…ter/engine#44960)
zanderso pushed a commit to flutter/flutter that referenced this pull request Aug 23, 2023
@engine-flutter-autoroll
Manual roll Flutter Engine from b190f9015049 to 7d56840865d2 (15 revi…
4bbcb78 
…sions) (#133106)

Manual roll requested by zra@google.com

flutter/engine@b190f90...7d56840

2023-08-23 zanderso@users.noreply.github.com Revert "Roll Dart SDK from
ab417bc74bb1 to c162b4979562 (1 revision)" (flutter/engine#44989)
2023-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
G25oJMO5jbUi-UN4F... to DoQ8KUxSk-5EU6VQ1... (flutter/engine#44988)
2023-08-23 zanderso@users.noreply.github.com Revert "Make `FontWeight`
an enum, Remove unused text classes" (flutter/engine#44987)
2023-08-23 skia-flutter-autoroll@skia.org Roll Dart SDK from
ab417bc74bb1 to c162b4979562 (1 revision) (flutter/engine#44986)
2023-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
kKI09su99b0AKs8b3... to VSvpNFoFjqXIQTcs6... (flutter/engine#44984)
2023-08-23 matanlurey@users.noreply.github.com Enable clang-tidy for
pre-push (opt-out), exclude `performance-unnecessary-value-param`
(flutter/engine#44936)
2023-08-22 john@johnmccutchan.com Restore old SurfaceTextureExternal
drawing code (flutter/engine#44979)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from d0918de21c1a to
aa208c8a2d60 (2 revisions) (flutter/engine#44981)
2023-08-22 jason-simmons@users.noreply.github.com Initialize the texture
destruction callback in the Metal embedder test harness
(flutter/engine#44973)
2023-08-22 matanlurey@users.noreply.github.com Further filter/clear
`<SkPaint>.setDither(true)`, this time in `DlSkPaintDispatchHelper`
(flutter/engine#44912)
2023-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from
3ebf0fedfceb to ab417bc74bb1 (1 revision) (flutter/engine#44977)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from bf6019be75ef to
d0918de21c1a (3 revisions) (flutter/engine#44975)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from c675298ddeda to
bf6019be75ef (3 revisions) (flutter/engine#44974)
2023-08-22 31859944+LongCatIsLooong@users.noreply.github.com Make
`FontWeight` an enum, Remove unused text classes (flutter/engine#44960)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 9f4b81aac175 to
c675298ddeda (2 revisions) (flutter/engine#44971)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from kKI09su99b0A to VSvpNFoFjqXI
  fuchsia/sdk/core/mac-amd64 from G25oJMO5jbUi to DoQ8KUxSk-5E

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
@engine-flutter-autoroll
2c4ada880 Make FontWeight an enum, Remove unused text classes (flut…
117071e 
…ter/engine#44960)
@reidbaker reidbaker mentioned this pull request Aug 25, 2023
Closed
8 tasks
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
@LongCatIsLooong @gaaclarke
Make FontWeight an enum, Remove unused text classes (flutter#44960)
8d298e6 
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
@zanderso @gaaclarke
Revert "Make FontWeight an enum, Remove unused text classes" (flutt…
2391d28 
…er#44987)

Reverts flutter#44960

Failing on customer_testing:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20customer_testing/59576/overview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LongCatIsLooong @jason-simmons