[Flutter Web(HTML)] fix: shader mask is painted incorrectly on shared offscreen canvas #44998

Kingtous · 2023-08-23T10:07:21Z

Hi from Dora team, which powers web developers to build their 3d websites in just a few seconds.

The size of the shared canvas should not only be updated if both width and height are not the same.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-08-23T10:07:23Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard · 2023-08-23T11:18:52Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #44998 at sha a1b0a38

Kingtous · 2023-09-06T03:17:45Z

Any updates here? :)

wanjm · 2023-09-23T23:21:08Z

Any updates here? :)
maybe you should ask for reviewer.

flutter-dashboard · 2023-10-13T23:22:41Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

harryterkelsen · 2023-12-05T23:33:29Z

The code LGTM. Can you please rebase on main so we can get up-to-date goldens on this PR? Thanks!

harryterkelsen

Please rebase on main

flutter-dashboard · 2024-02-07T00:33:32Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #44998 at sha 4cd4554

flutter-dashboard · 2024-04-17T00:09:48Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #44998 at sha 5b17cc6

auto-submit · 2024-07-03T17:38:20Z

auto label is removed for flutter/engine/44998, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

yjbanov

… on shared offscreen canvas (flutter/engine#44998)

…151293) flutter/engine@4190543...8e2d05f 2024-07-04 flar@google.com [Impeller] Re-enable fast blur path for elliptical rrects (flutter/engine#53704) 2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from 9fd1dc779589 to d5f8dde714e4 (2 revisions) (flutter/engine#53721) 2024-07-03 yjbanov@google.com [web] ignore pointer events on plain text spans (flutter/engine#53694) 2024-07-03 mdebbar@google.com Add Semantics Property `linkUrl` (flutter/engine#53507) 2024-07-03 chinmaygarde@google.com [Embedder] Document incorrectly named field in FlutterOpenGLFramebuffer. (flutter/engine#53720) 2024-07-03 chinmaygarde@google.com [Impeller] Make storage sizes typed. (flutter/engine#53700) 2024-07-03 matanlurey@users.noreply.github.com Convert `run_ios_tests.sh` to `run_ios_tests.dart`. (flutter/engine#53645) 2024-07-03 matanlurey@users.noreply.github.com Move `//third_party/android_embedding_dependencies` to `//flutter/third_party`. (flutter/engine#53587) 2024-07-03 chinmaygarde@google.com [Impeller] Document how to debug/profile OpenGL ES on macOS. (flutter/engine#53671) 2024-07-03 kingtous@qq.com [Flutter Web(HTML)] fix: shader mask is painted incorrectly on shared offscreen canvas (flutter/engine#44998) 2024-07-03 kingtous@qq.com fix: mask disappeared when having nested mask filter on Flutter web HTML (flutter/engine#45166) 2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from 86ee8cc61508 to 9fd1dc779589 (3 revisions) (flutter/engine#53715) 2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from c14cce59222b to 86ee8cc61508 (1 revision) (flutter/engine#53713) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#151293) flutter/engine@4190543...8e2d05f 2024-07-04 flar@google.com [Impeller] Re-enable fast blur path for elliptical rrects (flutter/engine#53704) 2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from 9fd1dc779589 to d5f8dde714e4 (2 revisions) (flutter/engine#53721) 2024-07-03 yjbanov@google.com [web] ignore pointer events on plain text spans (flutter/engine#53694) 2024-07-03 mdebbar@google.com Add Semantics Property `linkUrl` (flutter/engine#53507) 2024-07-03 chinmaygarde@google.com [Embedder] Document incorrectly named field in FlutterOpenGLFramebuffer. (flutter/engine#53720) 2024-07-03 chinmaygarde@google.com [Impeller] Make storage sizes typed. (flutter/engine#53700) 2024-07-03 matanlurey@users.noreply.github.com Convert `run_ios_tests.sh` to `run_ios_tests.dart`. (flutter/engine#53645) 2024-07-03 matanlurey@users.noreply.github.com Move `//third_party/android_embedding_dependencies` to `//flutter/third_party`. (flutter/engine#53587) 2024-07-03 chinmaygarde@google.com [Impeller] Document how to debug/profile OpenGL ES on macOS. (flutter/engine#53671) 2024-07-03 kingtous@qq.com [Flutter Web(HTML)] fix: shader mask is painted incorrectly on shared offscreen canvas (flutter/engine#44998) 2024-07-03 kingtous@qq.com fix: mask disappeared when having nested mask filter on Flutter web HTML (flutter/engine#45166) 2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from 86ee8cc61508 to 9fd1dc779589 (3 revisions) (flutter/engine#53715) 2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from c14cce59222b to 86ee8cc61508 (1 revision) (flutter/engine#53713) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added the platform-web Code specifically for the web engine label Aug 23, 2023

Kingtous force-pushed the fix/shader_canvas_mask branch from 4213baf to a1b0a38 Compare August 23, 2023 10:44

flutter-dashboard bot added the will affect goldens label Aug 23, 2023

harryterkelsen self-requested a review December 5, 2023 23:31

harryterkelsen requested changes Dec 5, 2023

View reviewed changes

Kingtous added 2 commits February 6, 2024 15:50

fix: shader mask is painted incorrectly on shared offscreen canvas

ff4f468

opt: add test

4cd4554

goderbauer force-pushed the fix/shader_canvas_mask branch from a1b0a38 to 4cd4554 Compare February 6, 2024 23:50

Merge branch 'main' into fix/shader_canvas_mask

5b17cc6

Merge branch 'main' into fix/shader_canvas_mask

42fceb2

harryterkelsen self-requested a review July 3, 2024 17:37

harryterkelsen approved these changes Jul 3, 2024

View reviewed changes

harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 3, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 3, 2024

yjbanov approved these changes Jul 3, 2024

View reviewed changes

harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 3, 2024

auto-submit bot merged commit 5ea3ea3 into flutter:main Jul 3, 2024
32 checks passed

engine-flutter-autoroll mentioned this pull request Jul 3, 2024

Roll Flutter Engine from 4190543cb093 to 5ea3ea389ab1 (4 revisions) flutter/flutter#151259

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2024

5ea3ea389 [Flutter Web(HTML)] fix: shader mask is painted incorrectly…

2181cfd

… on shared offscreen canvas (flutter/engine#44998)

engine-flutter-autoroll mentioned this pull request Jul 3, 2024

Roll Flutter Engine from 4190543cb093 to 84769c81cd6a (7 revisions) flutter/flutter#151264

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2024

5ea3ea389 [Flutter Web(HTML)] fix: shader mask is painted incorrectly…

65731fc

… on shared offscreen canvas (flutter/engine#44998)

engine-flutter-autoroll mentioned this pull request Jul 3, 2024

Roll Flutter Engine from 4190543cb093 to 1af5cef1432c (8 revisions) flutter/flutter#151270

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2024

5ea3ea389 [Flutter Web(HTML)] fix: shader mask is painted incorrectly…

c4db040

… on shared offscreen canvas (flutter/engine#44998)

engine-flutter-autoroll mentioned this pull request Jul 3, 2024

Roll Flutter Engine from 4190543cb093 to 31fd415056a3 (9 revisions) flutter/flutter#151275

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2024

5ea3ea389 [Flutter Web(HTML)] fix: shader mask is painted incorrectly…

e795dc7

… on shared offscreen canvas (flutter/engine#44998)

engine-flutter-autoroll mentioned this pull request Jul 3, 2024

Roll Flutter Engine from 4190543cb093 to 388547ac4ba8 (10 revisions) flutter/flutter#151278

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2024

5ea3ea389 [Flutter Web(HTML)] fix: shader mask is painted incorrectly…

9cd0521

… on shared offscreen canvas (flutter/engine#44998)

engine-flutter-autoroll mentioned this pull request Jul 3, 2024

Roll Flutter Engine from 4190543cb093 to 6db26bc1fbba (11 revisions) flutter/flutter#151285

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2024

5ea3ea389 [Flutter Web(HTML)] fix: shader mask is painted incorrectly…

b8a2f9d

… on shared offscreen canvas (flutter/engine#44998)

engine-flutter-autoroll mentioned this pull request Jul 4, 2024

Roll Flutter Engine from 4190543cb093 to aaf179cb1cc9 (12 revisions) flutter/flutter#151288

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2024

5ea3ea389 [Flutter Web(HTML)] fix: shader mask is painted incorrectly…

cf7b0e7

… on shared offscreen canvas (flutter/engine#44998)

engine-flutter-autoroll mentioned this pull request Jul 4, 2024

Roll Flutter Engine from 4190543cb093 to 8e2d05fa95d7 (13 revisions) flutter/flutter#151290

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2024

5ea3ea389 [Flutter Web(HTML)] fix: shader mask is painted incorrectly…

2d74186

… on shared offscreen canvas (flutter/engine#44998)

engine-flutter-autoroll mentioned this pull request Jul 4, 2024

Roll Flutter Engine from 4190543cb093 to 8e2d05fa95d7 (13 revisions) flutter/flutter#151293

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2024

5ea3ea389 [Flutter Web(HTML)] fix: shader mask is painted incorrectly…

5f8e716

… on shared offscreen canvas (flutter/engine#44998)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Flutter Web(HTML)] fix: shader mask is painted incorrectly on shared offscreen canvas #44998

[Flutter Web(HTML)] fix: shader mask is painted incorrectly on shared offscreen canvas #44998

Kingtous commented Aug 23, 2023 •

edited

Loading

flutter-dashboard bot commented Aug 23, 2023

flutter-dashboard bot commented Aug 23, 2023

Kingtous commented Sep 6, 2023

wanjm commented Sep 23, 2023

flutter-dashboard bot commented Oct 13, 2023

harryterkelsen commented Dec 5, 2023

harryterkelsen left a comment

flutter-dashboard bot commented Feb 7, 2024

flutter-dashboard bot commented Apr 17, 2024

auto-submit bot commented Jul 3, 2024

yjbanov left a comment

[Flutter Web(HTML)] fix: shader mask is painted incorrectly on shared offscreen canvas #44998

[Flutter Web(HTML)] fix: shader mask is painted incorrectly on shared offscreen canvas #44998

Conversation

Kingtous commented Aug 23, 2023 • edited Loading

Pre-launch Checklist

flutter-dashboard bot commented Aug 23, 2023

flutter-dashboard bot commented Aug 23, 2023

Kingtous commented Sep 6, 2023

wanjm commented Sep 23, 2023

flutter-dashboard bot commented Oct 13, 2023

harryterkelsen commented Dec 5, 2023

harryterkelsen left a comment

Choose a reason for hiding this comment

flutter-dashboard bot commented Feb 7, 2024

flutter-dashboard bot commented Apr 17, 2024

auto-submit bot commented Jul 3, 2024

yjbanov left a comment

Choose a reason for hiding this comment

Kingtous commented Aug 23, 2023 •

edited

Loading