Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] Add AbsorbOpacity enum. #45838

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

bdero
Copy link
Member

@bdero bdero commented Sep 14, 2023

@bdero bdero requested a review from chinmaygarde September 14, 2023 18:21
@bdero bdero self-assigned this Sep 14, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@bdero bdero force-pushed the bdero/absorb-opacity-enum branch from 1617874 to 0c9d606 Compare September 14, 2023 18:25
@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 14, 2023

auto label is removed for flutter/engine/45838, due to - The status or check suite Linux linux_arm_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023
@bdero bdero force-pushed the bdero/absorb-opacity-enum branch from 0c9d606 to 195cde7 Compare September 14, 2023 18:57
@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023
@auto-submit auto-submit bot merged commit 71b7045 into flutter:main Sep 14, 2023
26 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 14, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 14, 2023
…134778)

flutter/engine@3a3a280...683bca5

2023-09-14 bdero@google.com [Impeller] Assert IMPELLER_ENABLE_3D when importing scene_contents.h. (flutter/engine#45848)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 0f003d5748bc to 6bc9f5886ddf (2 revisions) (flutter/engine#45847)
2023-09-14 bdero@google.com [Impeller] Add AbsorbOpacity enum. (flutter/engine#45838)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
…lutter#134778)

flutter/engine@3a3a280...683bca5

2023-09-14 bdero@google.com [Impeller] Assert IMPELLER_ENABLE_3D when importing scene_contents.h. (flutter/engine#45848)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 0f003d5748bc to 6bc9f5886ddf (2 revisions) (flutter/engine#45847)
2023-09-14 bdero@google.com [Impeller] Add AbsorbOpacity enum. (flutter/engine#45838)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants