This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[Impeller] construct text frames on UI thread." #45910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8bacc3b.
jason-simmons
approved these changes
Sep 16, 2023
jonahwilliams
added
the
autosubmit
XilaiZhang
pushed a commit
to XilaiZhang/engine
that referenced
this pull request
Sep 16, 2023
Reverts flutter#45418 Some google3 tests are hitting the CHECK I added in the DlSkCanvasDispatcher::drawTextFrame, which indicates that the SkParagraph code likely thinks impeller is enabled, whereas other code might be running with Skia. Perhaps this could happen if its software rendering? It should be a fatal error on startup so we can track this down.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 16, 2023
…ions) (#134877) Manual roll requested by zra@google.com flutter/engine@30b7e9d...cdcbdcc 2023-09-16 jonahwilliams@google.com Revert "[Impeller] construct text frames on UI thread." (flutter/engine#45910) 2023-09-16 skia-flutter-autoroll@skia.org Roll Skia from 7c179932cc06 to c19cc483c619 (1 revision) (flutter/engine#45911) 2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 917fd16e6f26 to 7c179932cc06 (1 revision) (flutter/engine#45907) 2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 0057898979a1 to 917fd16e6f26 (1 revision) (flutter/engine#45906) 2023-09-15 matanlurey@users.noreply.github.com Do not convert an open path to a closed rect. (flutter/engine#45903) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
XilaiZhang
pushed a commit
to XilaiZhang/engine
that referenced
this pull request
Sep 18, 2023
Reverts flutter#45418 Some google3 tests are hitting the CHECK I added in the DlSkCanvasDispatcher::drawTextFrame, which indicates that the SkParagraph code likely thinks impeller is enabled, whereas other code might be running with Skia. Perhaps this could happen if its software rendering? It should be a fatal error on startup so we can track this down.
XilaiZhang
added a commit
that referenced
this pull request
Sep 18, 2023
…ad." (#45910) (#45958) Reverts #45418 Some google3 tests are hitting the CHECK I added in the DlSkCanvasDispatcher::drawTextFrame, which indicates that the SkParagraph code likely thinks impeller is enabled, whereas other code might be running with Skia. Perhaps this could happen if its software rendering? It should be a fatal error on startup so we can track this down. cherry pick for flutter roll Co-authored-by: Jonah Williams <jonahwilliams@google.com>
XilaiZhang
added a commit
to flutter/flutter
that referenced
this pull request
Sep 18, 2023
…t text frames on UI thread." (#134950) cherry picks flutter/engine#45910
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…ions) (flutter#134877) Manual roll requested by zra@google.com flutter/engine@30b7e9d...cdcbdcc 2023-09-16 jonahwilliams@google.com Revert "[Impeller] construct text frames on UI thread." (flutter/engine#45910) 2023-09-16 skia-flutter-autoroll@skia.org Roll Skia from 7c179932cc06 to c19cc483c619 (1 revision) (flutter/engine#45911) 2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 917fd16e6f26 to 7c179932cc06 (1 revision) (flutter/engine#45907) 2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 0057898979a1 to 917fd16e6f26 (1 revision) (flutter/engine#45906) 2023-09-15 matanlurey@users.noreply.github.com Do not convert an open path to a closed rect. (flutter/engine#45903) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Reverts #45418 Some google3 tests are hitting the CHECK I added in the DlSkCanvasDispatcher::drawTextFrame, which indicates that the SkParagraph code likely thinks impeller is enabled, whereas other code might be running with Skia. Perhaps this could happen if its software rendering? It should be a fatal error on startup so we can track this down.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #45418
Some google3 tests are hitting the CHECK I added in the DlSkCanvasDispatcher::drawTextFrame, which indicates that the SkParagraph code likely thinks impeller is enabled, whereas other code might be running with Skia.
Perhaps this could happen if its software rendering? It should be a fatal error on startup so we can track this down.