Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable checking headers with Clang Tidy. #46009

Merged
merged 16 commits into from
Sep 22, 2023
Merged

Enable checking headers with Clang Tidy. #46009

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3b46b0e
Enable checking headers with Clang Tidy.
matanlurey Sep 18, 2023
0511475
Tweak to ignore third_party.
matanlurey Sep 18, 2023
2ffebd6
Tweak.
matanlurey Sep 18, 2023
79feeb7
Tweak.
matanlurey Sep 18, 2023
d57bdac
USe --lint-all.
matanlurey Sep 19, 2023
f3376d2
Merge remote-tracking branch 'upstream/main' into engine-clang-tidy-c…
matanlurey Sep 19, 2023
cc557ee
Try something different.
matanlurey Sep 19, 2023
6a0f2f7
Do not use env variables.
matanlurey Sep 19, 2023
bcbe884
true -> false.
matanlurey Sep 19, 2023
22dd1c5
false -> 0.
matanlurey Sep 19, 2023
99af285
And back again.
matanlurey Sep 19, 2023
0d6bf65
Merge.
matanlurey Sep 21, 2023
92378ff
Tweak.
matanlurey Sep 21, 2023
2182440
Merge branch 'main' into engine-clang-tidy-check-headers
matanlurey Sep 21, 2023
ee3503f
Apply suggestions from code review
matanlurey Sep 22, 2023
a864589
Revert CI script changes.
matanlurey Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,11 @@ CheckOptions:
value: "lower_case"
- key: readability-identifier-naming.PrivateMemberSuffix
value: "_"

# Lint headers within paths that contain "/flutter/" but not:
# - gen (generated code, the fact it compiles is good enough™)
# - third_party (we didn't author most of the code, and can't fix the lints)
#
# Note this is because of our buildroot setup, so the full path of a lint is:
# "../../flutter/impeller/core/runtime_types.h:1:1" as reported.
HeaderFilterRegex: "(!third_party/)(!gen/).*/flutter/.*"